classification
Title: Typo of `immediatly` and `agin` words
Type: enhancement Stage: resolved
Components: Documentation, Extension Modules, Library (Lib) Versions: Python 3.4, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, python-dev, r.david.murray, vajrasky
Priority: normal Keywords: patch

Created on 2013-12-13 09:28 by vajrasky, last changed 2013-12-14 16:26 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
fix_typo_agin_and_immediatly_python34.patch vajrasky, 2013-12-13 09:28 review
fix_typo_agin_and_immediatly_python33.patch vajrasky, 2013-12-13 09:28 review
Messages (7)
msg206031 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-12-13 09:28
ethan@amiau:~/Documents/code/python/cpython3.4$ grep -R immediatly *
Doc/library/asyncio-protocol.rst::meth:`Transport.close` can be called immediatly after
Lib/test/test_signal.py:            # unblock the pending signal calls immediatly the signal handler
Modules/faulthandler.c:    /* call the previous signal handler: it is called immediatly if we use
ethan@amiau:~/Documents/code/python/cpython3.4$ grep -R " agin " *
Modules/posixmodule.c:           the symlink path agin and not the actual final path. */
Modules/posixmodule.c:           the symlink path agin and not the actual final path. */
msg206160 - (view) Author: Roundup Robot (python-dev) Date: 2013-12-14 01:54
New changeset 8e18a3b54bbe by R David Murray in branch '3.3':
#19970: Fix some comment typos.
http://hg.python.org/cpython/rev/8e18a3b54bbe

New changeset 358a35471f9f by R David Murray in branch 'default':
Merge: #19970: Fix some comment typos.
http://hg.python.org/cpython/rev/358a35471f9f
msg206161 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013-12-14 01:59
Thanks, Vajrasky.
msg206166 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-12-14 05:17
R. David Murray, there is a reason I create separate patches for 3.3 and 3.4. You couldn't just merge them. Python 3.4 has additional file with typo, which is immediatly in Doc/library/asyncio-protocol.rst. :)
msg206188 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013-12-14 16:21
Ah, well, it would be good to note that in the issue comments, then :).

The commit workflow is that a patch gets applied to a branch, then merged forward.  So I would need to apply the additional changes by hand to 3.4, unless you provide a 3.4 diff that is a diff between the *merged* 3.3 changeset and the updated 3.4 changes.  

Either way, let the committer know in the comments.  (I'll fix this momentarily.)
msg206189 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013-12-14 16:23
s/need/prefer/, unless the differences between the two patchsets are large, in which case I'd probably do a null merge followed by a separate 3.4 commit.
msg206190 - (view) Author: Roundup Robot (python-dev) Date: 2013-12-14 16:26
New changeset 561822250761 by R David Murray in branch 'default':
#19970: fix additional typo in 3.4 asyncio docs.
http://hg.python.org/cpython/rev/561822250761
History
Date User Action Args
2013-12-14 16:26:22python-devsetmessages: + msg206190
2013-12-14 16:23:13r.david.murraysetmessages: + msg206189
2013-12-14 16:21:56r.david.murraysetmessages: + msg206188
2013-12-14 05:17:33vajraskysetmessages: + msg206166
2013-12-14 01:59:01r.david.murraysetstatus: open -> closed

nosy: + r.david.murray
messages: + msg206161

resolution: fixed
stage: resolved
2013-12-14 01:54:16python-devsetnosy: + python-dev
messages: + msg206160
2013-12-13 09:28:57vajraskysetfiles: + fix_typo_agin_and_immediatly_python33.patch
2013-12-13 09:28:46vajraskycreate