classification
Title: Re-enable test_bug_1333982 on 3.x
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.4, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: ncoghlan, python-dev, serhiy.storchaka, zach.ware
Priority: normal Keywords: patch

Created on 2013-12-09 23:06 by zach.ware, last changed 2013-12-26 15:57 by zach.ware. This issue is now closed.

Files
File name Uploaded Description Edit
test_dis_1333982-3.3.diff zach.ware, 2013-12-09 23:06 Patch for 3.3 review
test_dis_1333982-3.4.diff zach.ware, 2013-12-09 23:06 Patch for 3.4 review
test_dis_1333982-3.4.v2.diff zach.ware, 2013-12-26 15:21 review
Messages (5)
msg205750 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-12-09 23:06
Here's a pair of patches which re-enable test_bug_1333982 in test_dis on 3.3 and 3.4; the major changes in 3.4 necessitate separate patches.  The patches also replace test_main with unittest.main which made trying to get the test to work much less annoying.
msg206940 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-12-26 15:21
Here's a much better patch to 3.4.
msg206941 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-12-26 15:29
LGTM.
msg206943 - (view) Author: Roundup Robot (python-dev) Date: 2013-12-26 15:55
New changeset e04fc45b7555 by Zachary Ware in branch '3.3':
Issue #19938: Re-enabled test_bug_1333982 in test_dis, which had been
http://hg.python.org/cpython/rev/e04fc45b7555

New changeset 285313c95e37 by Zachary Ware in branch 'default':
Issue #19938: Re-enabled test_bug_1333982 in test_dis, which had been
http://hg.python.org/cpython/rev/285313c95e37
msg206944 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-12-26 15:57
Committed; thanks for the review, Serhiy!  I made similar changes to the 3.3 patch before committing.
History
Date User Action Args
2013-12-26 15:57:11zach.waresetstatus: open -> closed
resolution: fixed
messages: + msg206944

stage: commit review -> resolved
2013-12-26 15:55:42python-devsetnosy: + python-dev
messages: + msg206943
2013-12-26 15:29:12serhiy.storchakasetassignee: zach.ware
messages: + msg206941
stage: patch review -> commit review
2013-12-26 15:21:05zach.waresetfiles: + test_dis_1333982-3.4.v2.diff

messages: + msg206940
2013-12-09 23:06:52zach.waresetfiles: + test_dis_1333982-3.4.diff
2013-12-09 23:06:36zach.warecreate