➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-12-06 16:12 by gvanrossum, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue19910_python.patch | Fotis.Koutoulakis, 2013-12-07 00:30 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg205383 - (view) | Author: Guido van Rossum (gvanrossum) *  |
Date: 2013-12-06 16:12 | |
compile() takes a string, bytes or AST as the "source" argument. The bytes option are not documented except in the error message you get when you pass something else. The AST option is in the library docs but not in the function docstring. |
|||
| msg205423 - (view) | Author: Fotis Koutoulakis (Fotis.Koutoulakis) * | Date: 2013-12-07 00:30 | |
There we go. I have changed the references to compile(), both in the docstring, and the documentation so that it states clearly that a bytes object is also acceptable as the "source" argument. I also fixed the docstring to mention explicitly that it can also accept an AST as the "source argument". Since this is my very first contribution to Python, I welcome all feedback. Thanks for your time. |
|||
| msg205424 - (view) | Author: Éric Araujo (eric.araujo) * |
Date: 2013-12-07 00:36 | |
Thanks! Patch looks good to me. |
|||
| msg205428 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-12-07 01:15 | |
New changeset 500cc1acc42f by Benjamin Peterson in branch '3.3': document that compile() can take bytes (closes #19910) http://hg.python.org/cpython/rev/500cc1acc42f New changeset 44dacafdd48a by Benjamin Peterson in branch 'default': merge 3.3 (#19910) http://hg.python.org/cpython/rev/44dacafdd48a |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:55 | admin | set | github: 64109 |
| 2013-12-07 01:15:03 | python-dev | set | status: open -> closed nosy: + python-dev messages: + msg205428 resolution: fixed stage: patch review -> resolved |
| 2013-12-07 00:59:58 | pitrou | set | nosy:
+ benjamin.peterson |
| 2013-12-07 00:36:28 | eric.araujo | set | keywords:
+ needs review messages: + msg205424 stage: needs patch -> patch review |
| 2013-12-07 00:30:49 | Fotis.Koutoulakis | set | files:
+ issue19910_python.patch nosy: + Fotis.Koutoulakis messages: + msg205423 keywords: + patch |
| 2013-12-06 17:29:17 | eric.araujo | set | nosy:
+ eric.araujo |
| 2013-12-06 16:14:31 | gvanrossum | set | keywords:
+ easy priority: normal -> low stage: needs patch |
| 2013-12-06 16:12:46 | gvanrossum | create | |