This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Misplaced private API method in pathlib.py
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: pitrou, python-dev, vajrasky
Priority: normal Keywords: patch

Created on 2013-12-01 14:36 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
move_private_method_to_its_place.patch vajrasky, 2013-12-01 14:36 review
Messages (3)
msg204926 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-12-01 14:36
In class Path, line 942, you have this comment:

# Public API

but down there, in line 1048, you have this private method:

    def _raw_open(self, flags, mode=0o777):
        """
        Open the file pointed by this path and return a file descriptor,
        as os.open() does.
        """
        if self._closed:
            self._raise_closed()
        return self._accessor.open(self, flags, mode)

Here is the patch to move this private method to where it belongs.
msg205053 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-12-02 20:25
New changeset cd8230437f40 by Antoine Pitrou in branch 'default':
Issue #19852: move Path._raw_open() around, as it is now a private method.
http://hg.python.org/cpython/rev/cd8230437f40
msg205054 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2013-12-02 20:26
Thanks! Patch now applied.
History
Date User Action Args
2022-04-11 14:57:54adminsetgithub: 64051
2013-12-02 20:26:09pitrousetstatus: open -> closed
resolution: fixed
messages: + msg205054

stage: resolved
2013-12-02 20:25:25python-devsetnosy: + python-dev
messages: + msg205053
2013-12-01 14:36:59vajraskycreate