This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: ConfigParser PEP issues
Type: Stage: resolved
Components: Library (Lib) Versions: Python 2.7
process
Status: closed Resolution: wont fix
Dependencies: Superseder:
Assigned To: Nosy List: Ivailo.Monev, berker.peksag, brianyardy, eric.araujo, r.david.murray
Priority: normal Keywords: patch

Created on 2013-11-30 13:16 by Ivailo.Monev, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
ConfigParser.patch Ivailo.Monev, 2013-11-30 13:16
Messages (6)
msg204808 - (view) Author: Ivailo Monev (Ivailo.Monev) Date: 2013-11-30 13:16
There are a few PEP violations like namespace clashes, the attached patch fixes some of them thus solving a problem for me where shared library build with Nuitka segmentation faults. The patch does not make the code backwards compatible with the vars and map arguments renames as there is no way to do that and maybe the new variable names, vvars and mmap are not appropriate but you can roll your own patch with the same idea.

Cheers!
msg204836 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013-11-30 18:56
Can you explain what the source of the problem is that you are trying to solve?  It sounds like a bug in Nuitka, whatever that is.

It is doubtful that this patch would be applied, for the backward compatibility reasons you cite.
msg204837 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013-11-30 18:58
Oh, and even if we decided there was enough reason to want to change the parameter names (which so far it doesn't look like there is), it could never be applied to 2.7, since the 2.7 API is frozen.
msg205390 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2013-12-06 17:42
Do you mean PEP 8 violations?  These aren’t usually enough to cause a change.
msg221684 - (view) Author: brian yardy (brianyardy) Date: 2014-06-27 12:11
Do you mean PEP 8 violations?  These aren’t usually enough to cause a change.'http://www.einstantloan.co.uk/'
msg260286 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-02-14 21:52
Thanks for the patch, Ivailo.

The following changes are going to break the public API:

    -    def get(self, section, option, raw=False, vars=None):
    +    def get(self, section, option, raw=False, vvars=None):

    -    def items(self, section, raw=False, vars=None):
    +    def items(self, section, raw=False, vvars=None):

Also,

    -class RawConfigParser:
    +class RawConfigParser(object):

There are a few differences between old-style and new-style classes. RawConfigParser implements collections.abs.MutableMapping so this isn't a problem in Python 3.

Closing this as "won't fix".
History
Date User Action Args
2022-04-11 14:57:54adminsetgithub: 64040
2016-02-14 21:52:35berker.peksagsetstatus: open -> closed

nosy: + berker.peksag
messages: + msg260286

resolution: wont fix
stage: resolved
2014-06-27 12:11:24brianyardysetnosy: + brianyardy
messages: + msg221684
2013-12-06 17:42:05eric.araujosetnosy: + eric.araujo
messages: + msg205390
2013-11-30 18:58:09r.david.murraysetmessages: + msg204837
2013-11-30 18:56:14r.david.murraysetnosy: + r.david.murray
messages: + msg204836
2013-11-30 13:16:59Ivailo.Monevcreate