Created on 2013-11-23 01:15 by pitrou, last changed 2013-11-23 14:23 by pitrou. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| utime_win.patch | pitrou, 2013-11-23 13:37 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg203943 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2013-11-23 01:15 | |
os.utime() uses the following code when times is None under Windows:
SYSTEMTIME now;
GetSystemTime(&now);
if (!SystemTimeToFileTime(&now, &mtime) ||
!SystemTimeToFileTime(&now, &atime)) {
PyErr_SetFromWindowsErr(0);
goto exit;
}
The problem is GetSystemTime has poor resolution (milliseconds). Instead, it could call GetSystemTimeAsFileTime which writes directly into a FILETIME structure, and potentially (?) has better resolution.
(according to a comment on MSDN, "Resolution on Windows 7 seems to be sub-millisecond": http://msdn.microsoft.com/en-us/library/windows/desktop/ms724397%28v=vs.85%29.aspx )
|
|||
| msg204007 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2013-11-23 13:33 | |
Here is a patch. |
|||
| msg204009 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2013-11-23 13:37 | |
Redoing (indentation issue). |
|||
| msg204022 - (view) | Author: STINNER Victor (haypo) * |
Date: 2013-11-23 14:02 | |
utime_win.patch looks good to me. |
|||
| msg204027 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-11-23 14:23 | |
New changeset 6a9e262c5423 by Antoine Pitrou in branch 'default': Issue #19727: os.utime(..., None) is now potentially more precise under Windows. http://hg.python.org/cpython/rev/6a9e262c5423 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-11-23 14:23:45 | pitrou | set | status: open -> closed resolution: fixed |
| 2013-11-23 14:23:33 | python-dev | set | nosy:
+ python-dev messages: + msg204027 |
| 2013-11-23 14:02:11 | haypo | set | nosy:
+ haypo messages: + msg204022 |
| 2013-11-23 13:41:54 | pitrou | set | files: - utime_win.patch |
| 2013-11-23 13:37:23 | pitrou | set | files:
+ utime_win.patch messages: + msg204009 |
| 2013-11-23 13:33:54 | pitrou | set | files:
+ utime_win.patch keywords: + patch messages: + msg204007 |
| 2013-11-23 01:15:52 | pitrou | create | |