➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-11-19 04:10 by zach.ware, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 19648.patch | gennad, 2013-12-15 21:14 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg203338 - (view) | Author: Zachary Ware (zach.ware) *  |
Date: 2013-11-19 04:10 | |
There are a couple of tests in pickletester that should either be implemented or removed, namely test_reduce and test_getinitargs of AbstractPickleTests. I don't know enough about pickling to suggest which route should be taken or how, so I'll leave that up to anyone who wants to write a patch :) |
|||
| msg206259 - (view) | Author: Gennadiy Zlobin (gennad) * | Date: 2013-12-15 21:14 | |
Hi, I created 2 simple tests for test_getinitargs and test_reduce. |
|||
| msg206633 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2013-12-19 19:22 | |
The patch looks good to me, but I can't claim to know enough about pickle to say whether the tests are correct. Alexandre or Antoine? |
|||
| msg206829 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2013-12-22 19:58 | |
The patch looks fine to me. Gennadiy, could you go and sign a contributor's agreement? http://www.python.org/psf/contrib/ Thanks very much. |
|||
| msg206911 - (view) | Author: Gennadiy Zlobin (gennad) * | Date: 2013-12-24 19:41 | |
Antoine, sure! I have just signed it. Thank you! |
|||
| msg207034 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-12-28 16:00 | |
New changeset fef075ddaec9 by Antoine Pitrou in branch 'default': Issue #19648: implement empty tests in pickletester. Patch by Gennadiy Zlobin. http://hg.python.org/cpython/rev/fef075ddaec9 |
|||
| msg207035 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2013-12-28 16:01 | |
I've pushed the patch. Thank you for your contribution! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:53 | admin | set | github: 63847 |
| 2013-12-28 16:01:27 | pitrou | set | status: open -> closed versions: - Python 3.3 messages: + msg207035 resolution: fixed stage: commit review -> resolved |
| 2013-12-28 16:00:23 | python-dev | set | nosy:
+ python-dev messages: + msg207034 |
| 2013-12-24 19:41:01 | gennad | set | messages: + msg206911 |
| 2013-12-22 19:58:39 | pitrou | set | stage: needs patch -> commit review |
| 2013-12-22 19:58:28 | pitrou | set | messages: + msg206829 |
| 2013-12-19 19:22:23 | zach.ware | set | messages: + msg206633 |
| 2013-12-15 21:14:39 | gennad | set | files:
+ 19648.patch nosy: + gennad messages: + msg206259 keywords: + patch |
| 2013-11-19 04:10:17 | zach.ware | create | |