This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Timeout in test_popen() of test_asyncio.test_windows_utils.PopenTests
Type: Stage:
Components: Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, python-dev, vstinner
Priority: normal Keywords:

Created on 2013-11-15 00:55 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (4)
msg202913 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-11-15 00:55
http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/7528/steps/test/logs/stdio

...
test_popen (test.test_asyncio.test_windows_utils.PopenTests) ... FAIL
test_winsocketpair (test.test_asyncio.test_windows_utils.WinsocketpairTests) ... ok
test_winsocketpair_exc (test.test_asyncio.test_windows_utils.WinsocketpairTests) ... ok

======================================================================
FAIL: test_popen (test.test_asyncio.test_windows_utils.PopenTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_asyncio\test_windows_utils.py", line 123, in test_popen
    self.assertEqual(res, _winapi.WAIT_OBJECT_0)
AssertionError: 258 != 0

----------------------------------------------------------------------

258 is the Windows error code for timeout: WAIT_TIMEOUT.

The timeout of 2 seconds if maybe too short for busy and slow Windows buildbots?
msg202915 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2013-11-15 01:06
Likely. Can you suggest a fix?
msg202934 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-11-15 10:23
> Likely. Can you suggest a fix?

Replace the timeout of 2 seconds with a timeout of 10 seconds.

It looks like the test checks the overlapped I/O API, not the timing.
If you want to test exactly the timing, another test is needed (ex:
measure the elapsed time and then ensure that the time is in a range).
msg202958 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-11-15 15:41
New changeset d48ec67b3b0e by Guido van Rossum in branch 'default':
asyncio: Longer timeout in Windows test_popen. Fixes issue 19598.
http://hg.python.org/cpython/rev/d48ec67b3b0e
History
Date User Action Args
2022-04-11 14:57:53adminsetgithub: 63797
2013-11-15 15:44:29vstinnersetstatus: open -> closed
resolution: fixed
2013-11-15 15:41:13python-devsetnosy: + python-dev
messages: + msg202958
2013-11-15 10:23:45vstinnersetmessages: + msg202934
2013-11-15 01:06:41gvanrossumsetmessages: + msg202915
2013-11-15 00:55:57vstinnercreate