➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-11-04 20:40 by Arnaud.Faure, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| modify_data.patch | Arnaud.Faure, 2013-11-04 20:40 | Add a shortcut to BaseSelector.modify when update data | ||
| modify_data.2.patch | Arnaud.Faure, 2013-11-04 22:35 | patch cpython default branch | review | |
| modify_data.3.patch | Arnaud.Faure, 2013-11-05 00:05 | review | ||
| modify_data_use_a_shortcut.patch | Arnaud.Faure, 2013-11-06 00:40 | Add a shortcut to BaseSelector.modify when update data | review | |
| Messages (6) | |||
|---|---|---|---|
| msg202172 - (view) | Author: Guido van Rossum (gvanrossum) *  |
Date: 2013-11-04 21:09 | |
The patch doesn't actually apply, not just because the pathnames are different, but because the unittests in Lib/test/test_selectors.py have a different structure. |
|||
| msg202176 - (view) | Author: Arnaud Faure (Arnaud.Faure) | Date: 2013-11-04 22:35 | |
Didn't thaught about that :( .... Did my way throught the developper tutorial, got the default cpython repo, did the modif, run patchcheck then the tests with ./python -m test -j3. Thanks for your patience ;) |
|||
| msg202177 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2013-11-04 22:48 | |
Check out my review: http://bugs.python.org/review/19497/#ps9821 |
|||
| msg202180 - (view) | Author: Arnaud Faure (Arnaud.Faure) | Date: 2013-11-05 00:05 | |
patch updated |
|||
| msg202249 - (view) | Author: Arnaud Faure (Arnaud.Faure) | Date: 2013-11-06 00:40 | |
Corrected and cleaned |
|||
| msg202369 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2013-11-07 17:13 | |
Fixed by revision 9c976f1b17e9. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:53 | admin | set | github: 63696 |
| 2013-11-07 17:13:54 | gvanrossum | set | status: open -> closed assignee: gvanrossum resolution: fixed messages: + msg202369 |
| 2013-11-06 00:40:58 | Arnaud.Faure | set | files:
+ modify_data_use_a_shortcut.patch messages: + msg202249 |
| 2013-11-05 00:05:14 | Arnaud.Faure | set | files:
+ modify_data.3.patch messages: + msg202180 |
| 2013-11-04 22:48:56 | gvanrossum | set | messages: + msg202177 |
| 2013-11-04 22:35:31 | Arnaud.Faure | set | files:
+ modify_data.2.patch messages: + msg202176 |
| 2013-11-04 21:09:56 | gvanrossum | set | messages: + msg202172 |
| 2013-11-04 20:58:38 | gvanrossum | set | nosy:
+ gvanrossum, neologix |
| 2013-11-04 20:40:21 | Arnaud.Faure | create | |