➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-11-04 12:57 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| skip_tests_distutils.patch | serhiy.storchaka, 2013-11-04 13:46 | review | ||
| Messages (8) | |||
|---|---|---|---|
| msg202123 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2013-11-04 12:57 | |
Some skipped distutils tests are reported as passed. Arfrever pointed out on some of these tests on IRC. Proposed patch adds explicit reporting them as skipped. See also issue18702. |
|||
| msg202128 - (view) | Author: Vajrasky Kok (vajrasky) * | Date: 2013-11-04 13:19 | |
You forgot to upload the "proposed patch", Serhiy. |
|||
| msg202136 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-11-04 13:46 | |
Thank you Vajrasky. |
|||
| msg202148 - (view) | Author: Arfrever Frehtes Taifersar Arahesis (Arfrever) *  |
Date: 2013-11-04 16:48 | |
> Lib/distutils/tests/test_build_ext.py ... > - ALREADY_TESTED = True > + ALREADY_TESTED = type(self).__name__ Why this change? > Lib/distutils/tests/test_build_ext.py ... > + @unittest.skipIf(sys.version < '2.6', > + 'site.USER_SITE was introduced in 2.6') > def test_user_site(self): > - # site.USER_SITE was introduced in 2.6 > - if sys.version < '2.6': > - return This check probably could be deleted. |
|||
| msg206203 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-12-14 22:41 | |
> Why this change? For better skip message (see a change above). |
|||
| msg206496 - (view) | Author: Éric Araujo (eric.araujo) * |
Date: 2013-12-18 05:15 | |
Alright. Patch looks good, thanks. |
|||
| msg206522 - (view) | Author: Roundup Robot (python-dev) |
Date: 2013-12-18 14:48 | |
New changeset b3f3e6afe966 by Serhiy Storchaka in branch '3.3': Issue #19492: Silently skipped distutils tests now reported as skipped. http://hg.python.org/cpython/rev/b3f3e6afe966 New changeset da3472687566 by Serhiy Storchaka in branch 'default': Issue #19492: Silently skipped distutils tests now reported as skipped. http://hg.python.org/cpython/rev/da3472687566 New changeset d5b0bb2a1790 by Serhiy Storchaka in branch '2.7': Issue #19492: Silently skipped distutils tests now reported as skipped. http://hg.python.org/cpython/rev/d5b0bb2a1790 |
|||
| msg206523 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-12-18 14:50 | |
Thanks Arfrever, Zachary and Éric for reviews. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:53 | admin | set | github: 63691 |
| 2013-12-18 14:50:37 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg206523 stage: patch review -> resolved |
| 2013-12-18 14:48:42 | python-dev | set | nosy:
+ python-dev messages: + msg206522 |
| 2013-12-18 05:15:20 | eric.araujo | set | assignee: eric.araujo -> serhiy.storchaka messages: + msg206496 |
| 2013-12-14 22:41:17 | serhiy.storchaka | set | messages: + msg206203 |
| 2013-11-13 20:43:46 | zach.ware | set | nosy:
+ zach.ware |
| 2013-11-04 16:48:39 | Arfrever | set | nosy:
+ Arfrever messages: + msg202148 |
| 2013-11-04 13:46:20 | serhiy.storchaka | set | files:
+ skip_tests_distutils.patch keywords: + patch messages: + msg202136 |
| 2013-11-04 13:19:03 | vajrasky | set | nosy:
+ vajrasky messages: + msg202128 |
| 2013-11-04 12:57:44 | serhiy.storchaka | create | |