Created on 2013-10-17 03:38 by David.Edelsohn, last changed 2013-10-18 15:26 by David.Edelsohn. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| wave_ppc64.patch | serhiy.storchaka, 2013-10-17 18:55 | review | ||
| Messages (11) | |||
|---|---|---|---|
| msg200116 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-10-17 09:52 | |
New changeset 73dad296c483 by Serhiy Storchaka in branch '2.7': Issue 19276: Fix tests for wave files on big-endian platforms. http://hg.python.org/cpython/rev/73dad296c483 New changeset 236884b40a2d by Serhiy Storchaka in branch '3.3': Issue 19276: Fix tests for wave files on big-endian platforms. http://hg.python.org/cpython/rev/236884b40a2d New changeset 8bdf5328c55b by Serhiy Storchaka in branch 'default': Issue 19276: Fix tests for wave files on big-endian platforms. http://hg.python.org/cpython/rev/8bdf5328c55b |
|||
| msg200127 - (view) | Author: David Edelsohn (David.Edelsohn) * | Date: 2013-10-17 13:55 | |
The patch does not appear to fix the tests for wave on big-endian PPC64 Linux. |
|||
| msg200130 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2013-10-17 14:31 | |
It fixed a bug in wave tests, but not a bug in the wave module. I'm working on this. |
|||
| msg200153 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-10-17 18:55 | |
What are array.array('l').itemsize and array.array('i').itemsize on PPC64 Linux?
I suppose that this patch should fix the wave module on 64-bit platforms.
|
|||
| msg200155 - (view) | Author: David Edelsohn (David.Edelsohn) * | Date: 2013-10-17 19:06 | |
>>> import array
>>> print array.array('l').itemsize
8
>>> print array.array('i').itemsize
4
|
|||
| msg200158 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-10-17 19:59 | |
Thank you David. I suspected this. |
|||
| msg200160 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2013-10-17 20:01 | |
For the record, why would this patch fix the issue? test_wave works fine under other 64-bit platforms. |
|||
| msg200162 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-10-17 20:05 | |
New changeset 9d2605f24a86 by Serhiy Storchaka in branch '2.7': Issue #19276: Fixed the wave module on 64-bit big-endian platforms. http://hg.python.org/cpython/rev/9d2605f24a86 New changeset a1a4a527c699 by Serhiy Storchaka in branch '3.3': Issue #19276: Fixed the wave module on 64-bit big-endian platforms. http://hg.python.org/cpython/rev/a1a4a527c699 New changeset 7e8ad3084891 by Serhiy Storchaka in branch 'default': Issue #19276: Fixed the wave module on 64-bit big-endian platforms. http://hg.python.org/cpython/rev/7e8ad3084891 |
|||
| msg200164 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-10-17 20:09 | |
Perhaps other 64-bit platforms are little-endian? |
|||
| msg200173 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-10-17 22:56 | |
Fixed. Thank you David for your report. |
|||
| msg200273 - (view) | Author: David Edelsohn (David.Edelsohn) * | Date: 2013-10-18 15:26 | |
Thanks! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-10-18 15:26:51 | David.Edelsohn | set | messages: + msg200273 |
| 2013-10-17 22:56:08 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg200173 stage: patch review -> resolved |
| 2013-10-17 20:09:35 | serhiy.storchaka | set | messages: + msg200164 |
| 2013-10-17 20:05:51 | python-dev | set | messages: + msg200162 |
| 2013-10-17 20:01:49 | pitrou | set | nosy:
+ pitrou messages: + msg200160 |
| 2013-10-17 19:59:05 | serhiy.storchaka | set | messages: + msg200158 |
| 2013-10-17 19:06:58 | David.Edelsohn | set | messages: + msg200155 |
| 2013-10-17 18:55:50 | serhiy.storchaka | set | stage: needs patch -> patch review |
| 2013-10-17 18:55:41 | serhiy.storchaka | set | files:
+ wave_ppc64.patch keywords: + patch messages: + msg200153 stage: needs patch |
| 2013-10-17 14:31:27 | serhiy.storchaka | set | messages: + msg200130 |
| 2013-10-17 13:55:03 | David.Edelsohn | set | messages: + msg200127 |
| 2013-10-17 09:52:32 | python-dev | set | nosy:
+ python-dev messages: + msg200116 |
| 2013-10-17 09:37:18 | serhiy.storchaka | set | assignee: serhiy.storchaka nosy: + serhiy.storchaka components: + Library (Lib), Tests, - Extension Modules versions: + Python 2.7, - Python 3.5 |
| 2013-10-17 03:38:02 | David.Edelsohn | create | |