Created on 2013-10-03 07:01 by eric.snow, last changed 2013-10-05 02:40 by eric.snow. This issue is now closed.
| Messages (12) | |||
|---|---|---|---|
| msg198886 - (view) | Author: Eric Snow (eric.snow) *  |
Date: 2013-10-03 07:01 | |
Any reason why ExtensionFileLoader does not implement get_filename()? I'm guessing it just slipped through the cracks. It should be there (and be registered as implementing ExecutionLoader). |
|||
| msg198896 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2013-10-03 13:44 | |
Just an oversight. |
|||
| msg198906 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-10-03 18:29 | |
New changeset 0d079c66dc23 by Eric Snow in branch 'default': [issue19152] Add ExtensionFileLoader.get_filename(). http://hg.python.org/cpython/rev/0d079c66dc23 |
|||
| msg198907 - (view) | Author: Eric Snow (eric.snow) * |
Date: 2013-10-03 18:41 | |
I realized after I committed that this should probably be back-ported to 3.3. I'll take care of that in a few hours. |
|||
| msg198914 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-10-03 19:53 | |
New changeset 832579dbafd6 by Eric Snow in branch '3.3': [issue19152] Add ExtensionFileLoader.get_filename(). http://hg.python.org/cpython/rev/832579dbafd6 |
|||
| msg198917 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2013-10-03 20:56 | |
Actually you need to back out the 3.3 commit. That's a new API in a bugfix release and that's bad. |
|||
| msg198918 - (view) | Author: Eric Snow (eric.snow) * |
Date: 2013-10-03 21:00 | |
Dang it. I was thinking of it as a bug that the method wasn't there, but you're right regardless. Revert coming. |
|||
| msg198919 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-10-03 21:21 | |
New changeset 7ed717bd5faa by Eric Snow in branch '3.3': [issue19152] Revert 832579dbafd6. http://hg.python.org/cpython/rev/7ed717bd5faa |
|||
| msg198920 - (view) | Author: Eric Snow (eric.snow) * |
Date: 2013-10-03 21:21 | |
Thanks for noticing that, Brett. |
|||
| msg198921 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2013-10-03 21:50 | |
It would be good to add a versionadded(or versionchanged) tag. |
|||
| msg198926 - (view) | Author: Eric Snow (eric.snow) * |
Date: 2013-10-03 22:26 | |
Good point. |
|||
| msg198978 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-10-05 02:40 | |
New changeset 62d045a873bb by Eric Snow in branch 'default': [issue 19152] Ensure we have actually registered ExtensionFileLoader as an ExecutionLoader. http://hg.python.org/cpython/rev/62d045a873bb New changeset e9554199620f by Eric Snow in branch 'default': [issue 19152] Add versionadded for ExtensionFileLoader.get_filename(). http://hg.python.org/cpython/rev/e9554199620f |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-10-05 02:40:32 | eric.snow | set | status: open -> closed |
| 2013-10-05 02:40:05 | python-dev | set | messages: + msg198978 |
| 2013-10-03 22:26:43 | eric.snow | set | status: closed -> open messages: + msg198926 |
| 2013-10-03 21:50:08 | berker.peksag | set | nosy:
+ berker.peksag messages: + msg198921 versions: - Python 3.3 |
| 2013-10-03 21:21:58 | eric.snow | set | status: open -> closed messages: + msg198920 |
| 2013-10-03 21:21:06 | python-dev | set | messages: + msg198919 |
| 2013-10-03 21:00:39 | eric.snow | set | messages: + msg198918 |
| 2013-10-03 20:56:27 | brett.cannon | set | status: closed -> open |
| 2013-10-03 20:56:12 | brett.cannon | set | messages: + msg198917 |
| 2013-10-03 19:55:07 | eric.snow | set | status: open -> closed resolution: fixed stage: resolved |
| 2013-10-03 19:53:19 | python-dev | set | messages: + msg198914 |
| 2013-10-03 18:41:47 | eric.snow | set | messages: + msg198907 |
| 2013-10-03 18:29:21 | python-dev | set | nosy:
+ python-dev messages: + msg198906 |
| 2013-10-03 13:44:10 | brett.cannon | set | messages: + msg198896 |
| 2013-10-03 07:01:35 | eric.snow | create | |