Created on 2013-10-03 06:15 by eric.snow, last changed 2013-10-03 19:56 by eric.snow. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| fix-get-supported-file-loaders.diff | eric.snow, 2013-10-03 06:15 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg198883 - (view) | Author: Eric Snow (eric.snow) *  |
Date: 2013-10-03 06:15 | |
Changeset 1db6553f3f8c for issue #15576 changed importlib._bootstrap._get_supported_file_loaders() to return a list of 2-tuples instead of 3-tuples. However, the docstring for the function was not updated to reflect that. More importantly, WindowsRegistryFinder.find_module() still expects 3-tuples. The fix is relatively trivial (patch attached). However, I'm not aware of any reports of problems related to what should be a very broken WindowsRegistryFinder. So I just wanted to double-check that I haven't missed something here. Undoubtedly the code simply hasn't gotten a lot of exposure since the patch (Aug. 2012). |
|||
| msg198895 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2013-10-03 13:41 | |
LGTM; just watch any Windows buildbot for possible failure. |
|||
| msg198908 - (view) | Author: Eric Snow (eric.snow) * |
Date: 2013-10-03 18:44 | |
changeset: 85941:152f7235667001fe7cb3c90ad79ab421ef8c03bb user: Eric Snow <ericsnowcurrently@gmail.com> date: Thu Oct 03 12:08:55 2013 -0600 summary: [issue19951] Fix docstring and use of _get_suppported_file_loaders() to reflect 2-tuples. (wrong issue # in commit message) |
|||
| msg198909 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-10-03 18:48 | |
New changeset a329474cfe0c by Eric Snow in branch 'default': [issue19151] Fix issue number in Misc/NEWS entry. http://hg.python.org/cpython/rev/a329474cfe0c |
|||
| msg198910 - (view) | Author: Eric Snow (eric.snow) * |
Date: 2013-10-03 18:49 | |
As with #19152, I'll need to backport this to 3.3. |
|||
| msg198913 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-10-03 19:53 | |
New changeset 32b18998a560 by Eric Snow in branch '3.3': [issue19151] Fix docstring and use of _get_suppported_file_loaders() to reflect 2-tuples. http://hg.python.org/cpython/rev/32b18998a560 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-10-03 19:56:01 | eric.snow | set | status: open -> closed resolution: fixed stage: commit review -> resolved |
| 2013-10-03 19:53:19 | python-dev | set | messages: + msg198913 |
| 2013-10-03 18:49:52 | eric.snow | set | messages: + msg198910 |
| 2013-10-03 18:48:46 | python-dev | set | nosy:
+ python-dev messages: + msg198909 |
| 2013-10-03 18:44:11 | eric.snow | set | messages: + msg198908 |
| 2013-10-03 13:41:50 | brett.cannon | set | messages: + msg198895 |
| 2013-10-03 06:15:48 | eric.snow | create | |