This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: tix.py uses StringType
Type: behavior Stage: resolved
Components: Tkinter Versions: Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: gpolo, python-dev, serhiy.storchaka, terry.reedy
Priority: normal Keywords: easy, patch

Created on 2013-09-15 20:59 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
tix_StringType.patch serhiy.storchaka, 2013-09-15 20:59 review
Messages (4)
msg197834 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-09-15 20:59
Lib/tkinter/tix.py uses the StringType name which is not defined. This is a remnant from 2.x where the StringType type was imported from the types module. In 3.x it gone and was replaced by str in Lib/tkinter/__init__.py.

The proposed patch fixes it also in tix.py.
msg197841 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2013-09-15 23:22
I am slightly surprised no one has complained about a NameError. I guess tix is untested and not used too much, or at least not the two methods, tixCommand.tix_configure and TixWidget.config_all.  Anyway, do it.
msg197870 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-09-16 05:43
I guess this code executed only when wantobjects is false.
msg197877 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-09-16 08:04
New changeset 9eab3e745061 by Serhiy Storchaka in branch '3.3':
Issue #19029: Change non-existing since 3.0 StringType to str.
http://hg.python.org/cpython/rev/9eab3e745061

New changeset 95b3efe3d7b7 by Serhiy Storchaka in branch 'default':
Issue #19029: Change non-existing since 3.0 StringType to str.
http://hg.python.org/cpython/rev/95b3efe3d7b7
History
Date User Action Args
2022-04-11 14:57:51adminsetgithub: 63229
2013-09-16 08:52:19serhiy.storchakasetstatus: open -> closed
assignee: serhiy.storchaka
resolution: fixed
stage: patch review -> resolved
2013-09-16 08:04:32python-devsetnosy: + python-dev
messages: + msg197877
2013-09-16 05:43:47serhiy.storchakasetmessages: + msg197870
2013-09-15 23:22:46terry.reedysetmessages: + msg197841
2013-09-15 20:59:44serhiy.storchakacreate