Cannot compile _ssl module when openssl version > 1.0 and it is configured with turned on macro OPENSSL_NO_DEPRECATED

Everything looks like in recent versions of openssl routine 'CRYPTO_set_id_callback' has gone away.

Patch suggested.

Rather than removing the call to CRYPTO_set_id_callback, it seems we should replace it with CRYPTO_THREADID_set_callback:

« CRYPTO_THREADID and associated functions were introduced in OpenSSL 1.0.0 to replace (actually, deprecate) the previous CRYPTO_set_id_callback(), CRYPTO_get_id_callback(), and CRYPTO_thread_id() functions which assumed thread IDs to always be represented by 'unsigned long'. »

http://www.openssl.org/docs/crypto/threads.html

Something like that:

static void
_ssl_threadid_callback(CRYPTO_THREADID *id)
{
    CRYPTO_THREADID_set_numeric(id, PyThread_get_thread_ident());
}

CRYPTO_THREADID_set_callback(_ssl_threadid_callback);

I'm going to work on a modified patch.

Indeed, only with the proper #ifdef's :-)

patch

New changeset f967ded6f9dd by Christian Heimes in branch '3.3':
Issue #18777: The ssl module now uses the new CRYPTO_THREADID API of
http://hg.python.org/cpython/rev/f967ded6f9dd

New changeset 28e68f4807a2 by Christian Heimes in branch 'default':
Issue #18777: The ssl module now uses the new CRYPTO_THREADID API of
http://hg.python.org/cpython/rev/28e68f4807a2

New changeset 5d691723bfbd by Christian Heimes in branch '2.7':
Issue #18777: The ssl module now uses the new CRYPTO_THREADID API of
http://hg.python.org/cpython/rev/5d691723bfbd

The hpux bot fails at the compile stage:

http://buildbot.python.org/all/builders/IA64%20HP-UX%2011iv3%20%5BSB%5D%203.x/builds/2152/steps/compile/logs/stdio


ld -b build/temp.hp-ux-B.11.31-ia64-3.4-pydebug/home/cpython/buildslave/3.x.snakebite-hpux11iv3-ia64-1/build/Modules/_ssl.o -L/usr/local/lib -lssl -lcrypto -o build/lib.hp-ux-B.11.31-ia64-3.4-pydebug/_ssl.so
/usr/lib/hpux32/dld.so: Unsatisfied code symbol 'CRYPTO_THREADID_set_callback' in load module 'build/lib.hp-ux-B.11.31-ia64-3.4-pydebug/_ssl.so'.
sh[5]: 7508 Killed
*** Error exit code 137

Trent, can you have a look? There seems to be a hickup with the linker and dynamic loader. Python picks up the ssl libraries from /usr/lib instead of /usr/local/lib

ld -b build/temp.hp-ux-B.11.31-ia64-3.4/home/cpython/cpython/Modules/_ssl.o -L/usr/local/lib -lssl -lcrypto -o build/lib.hp-ux-B.11.31-ia64-3.4/_ssl.so
/usr/lib/hpux32/dld.so: Unsatisfied code symbol 'CRYPTO_THREADID_set_callback' in load module 'build/lib.hp-ux-B.11.31-ia64-3.4/_ssl.so'.
% ldd build/lib.hp-ux-B.11.31-ia64-3.4/_ssl.so
        libssl.so.1 =>  /usr/lib/hpux32/libssl.so.1
        libcrypto.so.1 =>       /usr/lib/hpux32/libcrypto.so.1
        libdl.so.1 =>   /usr/lib/hpux32/libdl.so.1
        libc.so.1 =>    /usr/lib/hpux32/libc.so.1
        libdl.so.1 =>   /usr/lib/hpux32/libdl.so.1
% strings /usr/lib/hpux32/libcrypto.so.1 | grep -i thread 
__thread_specific_seg
BN_BLINDING_get_thread_id
BN_BLINDING_set_thread_id
CRYPTO_thread_id

----
But:

% strings /usr/local/lib/hpux32/libcrypto.so | grep -i thread 
__thread_specific_seg
BN_BLINDING_get_thread_id
BN_BLINDING_set_thread_id
CRYPTO_THREADID_current
CRYPTO_THREADID_set_numeric
CRYPTO_THREADID_get_callback
CRYPTO_THREADID_set_callback



Christian

This is marked as fixed but am still seeing this error in 2.7.12 on HP-UX 11.31.

/opt/hp-gcc64-4.7.1/bin/gcc -pthread -shared build/temp.hp-ux-B.11.31-9000-800-2.7/root/build/Python-2.7.12/Modules/_ssl.o -L/usr/local/lib -lssl -lcrypto -o build/lib.hp-ux-B.11.31-9000-800-2.7/_ssl.sl
/usr/lib/pa20_64/dld.sl: Unsatisfied code symbol 'CRYPTO_THREADID_set_callback' in load module 'build/lib.hp-ux-B.11.31-9000-800-2.7/_ssl.sl'.
/bin/sh: 23510 Killed
gmake: *** [sharedmods] Error 137

James, double check you specify the right path to the local system libraries.  If the system is multilib, libssl resides in /usr/local/lib/hpux32 (64) and not in /usr/local/lib directly.