Created on 2013-08-10 10:21 by serhiy.storchaka, last changed 2013-08-16 22:04 by python-dev. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| no_version_checks.patch | serhiy.storchaka, 2013-08-10 10:21 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg194789 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2013-08-10 10:21 | |
Here is a patch which removes PY_VERSION_HEX checks in Modules/_ctypes/_ctypes.c, Modules/_sre.c, Objects/stringlib/unicodedefs.h and removes the Modules/_sqlite/sqlitecompat.h file. _sre.c checks support Python versions <2.2, <2.2 or <1.6 which doesn't made sense because the code overall uses Unicode object API available only in Python >=3.3. unicodedefs.h contains code to support Python <3.0, but stringlib code can't be shared with Python <3.3. _ctypes.c and sqlitecompat.h contain code to support Python <2.5 which is not supported version. |
|||
| msg195377 - (view) | Author: Ezio Melotti (ezio.melotti) * |
Date: 2013-08-16 17:41 | |
LGTM. |
|||
| msg195427 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-08-16 21:50 | |
New changeset a04d957c8d07 by Serhiy Storchaka in branch 'default': Issue #18701: Remove support of old CPython versions (<3.0) from C code. http://hg.python.org/cpython/rev/a04d957c8d07 |
|||
| msg195429 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2013-08-16 21:56 | |
Your commit forgot to remove sqlitecompat.h. |
|||
| msg195430 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-08-16 22:03 | |
Oh, I forgot that this patch need `hg import` instead of `patch --merge -p1`. Thank you Antoine. |
|||
| msg195431 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-08-16 22:04 | |
New changeset 2150c7d6426c by Serhiy Storchaka in branch 'default': Issue #18701: Remove sqlitecompat.h. http://hg.python.org/cpython/rev/2150c7d6426c |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-08-16 22:04:09 | python-dev | set | messages: + msg195431 |
| 2013-08-16 22:03:22 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg195430 stage: patch review -> resolved |
| 2013-08-16 21:56:15 | pitrou | set | messages: + msg195429 |
| 2013-08-16 21:50:29 | python-dev | set | nosy:
+ python-dev messages: + msg195427 |
| 2013-08-16 17:41:32 | ezio.melotti | set | messages: + msg195377 |
| 2013-08-10 10:21:53 | serhiy.storchaka | create | |