Implementation of the PEP 446.

+    if (make_inheritable(py_fds_to_keep) < 0)
+        goto error;
+    /* errpipe_write is part of py_fds_to_keep. It must be closed at
+       exec(), but kept open in the child process until exec() is called. */
+    if (_Py_set_inheritable((int)errpipe_write, 0, NULL) < 0)
+        goto error;

make_inheritable() should ignore errpipe_write, instead of changing twice the inheritable flag of errpipe_write.

> make_inheritable() should ignore errpipe_write, instead of changing twice the inheritable flag of errpipe_write.

Done in the last patch (00df7fc6d2ef.diff).

I tested 17211acb65b1.diff on my x86_64 VMs:

Linux: Linux-3.9.4-200.fc18.x86_64-x86_64-with-fedora-18-Spherical_Cow
=> 358 tests OK.

OpenIndiana: Solaris-2.11-i86pc-i386-32bit-ELF
=> 3 tests failed: test_locale test_tcl test_uuid -- none of these failures are related to the PEP and also occurs in default

Mac OS X: Darwin-10.8.0-i386-64bit
=> 352 tests OK.

FreeBSD: FreeBSD-9.1-RELEASE-amd64-64bit-ELF
=> 351 tests OK.

Windows: Windows-7-6.1.7601-SP1
=> 329 tests OK

So it works on all (tested) platforms ;-)

New changeset ef889c3d5dc6 by Victor Stinner in branch 'default':
Issue #18571: Implementation of the PEP 446: file descriptors and file handles
http://hg.python.org/cpython/rev/ef889c3d5dc6

14.1 --- a/Lib/multiprocessing/util.py
    14.2 +++ b/Lib/multiprocessing/util.py

   14.13  #
   14.14  # Return pipe with CLOEXEC set on fds
   14.15  #
   14.16 +# Deprecated: os.pipe() creates non-inheritable file descriptors
   14.17 +# since Python 3.4
   14.18 +#
   14.19  
   14.20  def pipe():
   14.21 -    import _posixsubprocess
   14.22 -    return _posixsubprocess.cloexec_pipe()
   14.23 +    return os.pipe()

I guess you could remove util.pipe() altogether: it wasn't part of the public API.

> I guess you could remove util.pipe() altogether: it wasn't part of the public API.

Ah yes, I wanted to create an issue for that but I forgot. Here you
have: issue #18865.

New changeset c27527dce71e by Victor Stinner in branch 'default':
Issue #18571: Merge duplicate test code
http://hg.python.org/cpython/rev/c27527dce71e