Created on 2013-07-20 12:40 by christian.heimes, last changed 2013-07-21 14:26 by christian.heimes. This issue is now closed.
| Messages (6) | |||
|---|---|---|---|
| msg193406 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2013-07-20 12:40 | |
http://hg.python.org/cpython/file/a65856044ad4/Modules/_ctypes/_ctypes.c#l2673 Coverity analysis: 2672 } else { /* copy contents of adr */ 2673 if (-1 == PyCData_MallocBuffer(cmem, dict)) { 2674 return NULL; CID 715381: Structurally dead code (UNREACHABLE)unreachable: This code cannot be reached: "do { PyObject *_py_decref...". 2675 Py_DECREF(cmem); 2676 } |
|||
| msg193445 - (view) | Author: Eric V. Smith (eric.smith) * |
Date: 2013-07-21 13:46 | |
Your patch looks like the output of "hg help", or similar. |
|||
| msg193447 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2013-07-21 14:06 | |
Oh, you are right ... The patch is trivial: I switched the Py_DECREF() and return NULL lines. |
|||
| msg193448 - (view) | Author: Eric V. Smith (eric.smith) * |
Date: 2013-07-21 14:09 | |
For some reason the blank link in the Coverity report confused me. Yes, swapping the lines looks right. |
|||
| msg193452 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-07-21 14:25 | |
New changeset 25ffad2e12d6 by Christian Heimes in branch '3.3': Issue #18514: Fix unreachable Py_DECREF() call in PyCData_FromBaseObj() http://hg.python.org/cpython/rev/25ffad2e12d6 New changeset afe119a3619f by Christian Heimes in branch 'default': Issue #18514: Fix unreachable Py_DECREF() call in PyCData_FromBaseObj() http://hg.python.org/cpython/rev/afe119a3619f |
|||
| msg193453 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2013-07-21 14:26 | |
Thanks for the review |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-07-21 14:26:59 | christian.heimes | set | status: open -> closed resolution: fixed messages: + msg193453 stage: needs patch -> resolved |
| 2013-07-21 14:25:41 | python-dev | set | nosy:
+ python-dev messages: + msg193452 |
| 2013-07-21 14:09:04 | eric.smith | set | messages: + msg193448 |
| 2013-07-21 14:06:54 | christian.heimes | set | messages: + msg193447 |
| 2013-07-21 14:05:41 | christian.heimes | set | files: - frombaseobj.patch |
| 2013-07-21 13:46:26 | eric.smith | set | nosy:
+ eric.smith messages: + msg193445 |
| 2013-07-20 12:40:37 | christian.heimes | create | |