The _elementtree extension calls PyType_Ready for most, but not all, types defined in the extension. The attached patch calls PyType_Ready for the ElementIter_Type.

Good catch!

ElementIter_Type has no prototype, too.

$ grep Type Modules/_elementtree.c  | grep static
static PyTypeObject Element_Type;
static PyTypeObject Element_Type = {
static PyTypeObject ElementIter_Type = {
static PyTypeObject TreeBuilder_Type;
static PyTypeObject TreeBuilder_Type = {
static PyTypeObject XMLParser_Type;
static PyTypeObject XMLParser_Type = {

How about you move the prototypes for all four types to the head of the file? For example the ssl.c module declares all types up front. It makes it more clear which types are defined by the module.

It was a pretty easy catch, the _elementtree caused a crash while I was working on an implementation for PEP 447.  The missing call to PyType_Ready helped to make that implementation more robust :-)

I'm not entirely convinced that adding forward declarations for the type is really useful, but have added a patch that moves the forward declarations to the start of the file and adds one for the iter type.

LGTM, thanks.

New changeset cd4c9d4bd88f by Ronald Oussoren in branch '3.3':
#18480: Add missing PyType_Ready call to _elementtree extension
http://hg.python.org/cpython/rev/cd4c9d4bd88f

New changeset 7362722646f7 by Ronald Oussoren in branch 'default':
(3.3->default): #18480: Add missing PyType_Ready call to _elementtree extension
http://hg.python.org/cpython/rev/7362722646f7