classification
Title: Fix and cleanup the ss1.py demo
Type: behavior Stage: resolved
Components: Demos and Tools Versions: Python 3.4, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: iwontbecreative, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2013-07-15 12:07 by serhiy.storchaka, last changed 2013-07-16 19:40 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
demo_ss1.patch serhiy.storchaka, 2013-07-15 12:07 review
Messages (4)
msg193089 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-07-15 12:07
Here is a patch which fixes some bugs in Tools/demo/ss1.py:

* Saving formulas containing & and < symbols.
* Saving complex numbers.

Also it a little cleanups the code:

* Using xml.sax.saxutils.escape instead of html.escape.
* Using the with statement for file I/O.
* Removed out-of-dated and redundant code.

On Python 2 the ss1.py demo is totally broken due to using out-of-dated rexec module.
msg193094 - (view) Author: FĂ©vry Thibault (iwontbecreative) * Date: 2013-07-15 12:39
These are some nice improvements, but there is still a crash if you type =1000**5000 .
msg193098 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-07-15 13:39
Thank you for report. This is a separated issue #18461.
msg193185 - (view) Author: Roundup Robot (python-dev) Date: 2013-07-16 18:59
New changeset 9098a4ad4d3e by Serhiy Storchaka in branch '3.3':
Issue #18457: Fixed saving of formulas and complex numbers in Tools/demo/ss1.py.
http://hg.python.org/cpython/rev/9098a4ad4d3e

New changeset c6b91d894577 by Serhiy Storchaka in branch 'default':
Issue #18457: Fixed saving of formulas and complex numbers in Tools/demo/ss1.py.
http://hg.python.org/cpython/rev/c6b91d894577
History
Date User Action Args
2013-07-16 19:40:43serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2013-07-16 18:59:43python-devsetnosy: + python-dev
messages: + msg193185
2013-07-15 13:39:31serhiy.storchakasetmessages: + msg193098
2013-07-15 12:39:33iwontbecreativesetnosy: + iwontbecreative
messages: + msg193094
2013-07-15 12:07:20serhiy.storchakacreate