This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: There are unused variables inside DateTimeTestCase class in test_xmlrpc.py
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: belopolsky, ezio.melotti, python-dev, vajrasky
Priority: normal Keywords:

Created on 2013-07-14 15:58 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fix_DateTimeTestCase.txt vajrasky, 2013-07-14 15:58 Fix for unit test inside DateTimeTestCase class in test_xmlrpc.py review
fix_DateTimeTestCase_using_mock_object.txt vajrasky, 2013-07-14 16:33 Fix for unit test inside DateTimeTestCase class in test_xmlrpc.py using mock object review
Messages (5)
msg193059 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-07-14 15:58
Attached the menial fix to unit test in test_xmlrpc.py.
msg193061 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-07-14 16:33
Okay, instead of using computer timer, I use mock object instead.
msg193485 - (view) Author: Alexander Belopolsky (belopolsky) * (Python committer) Date: 2013-07-22 02:31
LGTM
msg194805 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-08-10 15:37
New changeset 28c756093a63 by Ezio Melotti in branch '3.3':
#18453: fix unused variables in test_xmlrpc.  Patch by Vajrasky Kok.
http://hg.python.org/cpython/rev/28c756093a63

New changeset 9f7581816890 by Ezio Melotti in branch 'default':
#18453: merge with 3.3.
http://hg.python.org/cpython/rev/9f7581816890
msg194806 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-08-10 15:38
Fixed, thanks for the report and the patch!
History
Date User Action Args
2022-04-11 14:57:48adminsetgithub: 62653
2013-08-10 15:38:22ezio.melottisetstatus: open -> closed

type: enhancement
assignee: ezio.melotti
versions: + Python 3.3
nosy: + ezio.melotti

messages: + msg194806
resolution: fixed
stage: resolved
2013-08-10 15:37:56python-devsetnosy: + python-dev
messages: + msg194805
2013-07-22 02:31:00belopolskysetmessages: + msg193485
2013-07-19 21:19:34terry.reedysetnosy: + belopolsky
2013-07-14 16:33:02vajraskysetfiles: + fix_DateTimeTestCase_using_mock_object.txt

messages: + msg193061
2013-07-14 15:58:59vajraskycreate