This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Finding perl64
Type: compile error Stage: resolved
Components: Build, Windows Versions: Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, christian.heimes, loewis, mjdorma, python-dev, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2013-07-08 05:37 by mjdorma, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
build_ssl_with_perl64.patch mjdorma, 2013-07-08 05:37 PCBuild\build_ssl.py review
Messages (11)
msg192615 - (view) Author: Michael Dorman (mjdorma) * Date: 2013-07-08 05:37
Perl64 installs into C:\perl64\bin

Can we include this path in the search list?
msg192646 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2013-07-08 12:47
I don't mind to add perl64 to the search path.
msg192810 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2013-07-10 13:57
OTOH, perl is not a prerequisite in the first place for building Python with OpenSSL. Why do you think you need it?
msg224352 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2014-07-30 22:07
Can ths be closed as "not a bug"?
msg224424 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2014-07-31 15:59
At one point the version of OpenSSL on svn.python.org did not have the correct makefiles for a 64-bit Windows build, but this was resolved. You also don't need 64-bit Perl to generate these files, and the file has been renamed to "prepare_ssl.py" and appears to only be used for creating the makefiles for checking into SVN (perhaps it should move to Tools?).

It's a trivial patch, but considering I don't even know who runs the file, I'm not going to go and mess with it. Zach and/or Tim presumably know.
msg225284 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-08-13 18:18
It's a harmless patch, but not especially necessary.  If you need the perl.exe that's in C:\Perl64\bin, just do "set PATH=C:\Perl64\bin;%PATH%" before you invoke the script.
msg240408 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-04-10 03:49
There is no longer a build_ssl.py file in the PCBuild directory so can this be closed.
msg240410 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2015-04-10 03:56
build_ssl.py is now prepare_ssl.py, the patch still applies to 2.7 and 3.4 as well.
msg240630 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-04-13 15:53
New changeset 069dd1e347b4 by Zachary Ware in branch '2.7':
Issue #18402: Also look for 64 bit Perl in build_ssl.py.
https://hg.python.org/cpython/rev/069dd1e347b4

New changeset cf19bd089768 by Zachary Ware in branch '3.4':
Issue #18402: Also look for 64 bit Perl in build_ssl.py.
https://hg.python.org/cpython/rev/cf19bd089768

New changeset ef6c4712cc28 by Zachary Ware in branch 'default':
Closes #18402: Merge with 3.4
https://hg.python.org/cpython/rev/ef6c4712cc28
msg240638 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2015-04-13 16:04
Michael, I failed to attribute you in the commit messages, sorry about that.  Thanks for the patch!
msg240641 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-04-13 16:09
New changeset dc65187be892 by Zachary Ware in branch '2.7':
Attribute Michael Dorman for his initial patch on issue #18402.
https://hg.python.org/cpython/rev/dc65187be892

New changeset 19f6f339af7e by Zachary Ware in branch '3.4':
Attribute Michael Dorman for his initial patch on issue #18402.
https://hg.python.org/cpython/rev/19f6f339af7e
History
Date User Action Args
2022-04-11 14:57:47adminsetgithub: 62602
2015-04-13 16:09:08python-devsetmessages: + msg240641
2015-04-13 16:04:10zach.waresetmessages: + msg240638
2015-04-13 15:53:24python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg240630

resolution: fixed
stage: patch review -> resolved
2015-04-10 03:56:09zach.waresetmessages: + msg240410
versions: + Python 2.7, Python 3.5
2015-04-10 03:49:09BreamoreBoysetmessages: + msg240408
2014-08-13 18:18:08zach.waresetmessages: + msg225284
2014-07-31 15:59:26steve.dowersetnosy: + tim.golden, zach.ware
messages: + msg224424
2014-07-31 01:32:18pitrousetnosy: + steve.dower
2014-07-30 22:07:19BreamoreBoysetnosy: + BreamoreBoy, - brian.curtin
messages: + msg224352
2013-07-10 13:57:15loewissetnosy: + loewis
messages: + msg192810
2013-07-08 12:47:35christian.heimessetnosy: + christian.heimes
messages: + msg192646

components: + Windows
stage: patch review
2013-07-08 05:37:53mjdormacreate