➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-06-13 08:03 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_coding.patch | serhiy.storchaka, 2013-06-13 08:04 | Patch for 3.3 | review | |
| Messages (4) | |||
|---|---|---|---|
| msg191066 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2013-06-13 08:03 | |
Here is a patch which contains followed changes: * Use bytes in test_exec_valid_coding(). Encoding instruction is ignored in strings. * Use non-ascii data in test_exec_valid_coding() to check that encoding is working. * Use explicit file encoding in test_file_parse(). * Use with statement for file in test_file_parse(). * Modify sys.path after opening file in test_file_parse() and restore before other cleanups. * Cleanup '.pyo' file in test_file_parse(). Test can ran in optimized mode. * Add msg parameter for better failure reporting in test_error_from_string(). * Use unittest.main(). |
|||
| msg191438 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2013-06-18 22:24 | |
The patch looks good to me. It may be better to split it in two commits: fix test_exec_valid_coding() in Python 3.3, cleanup test only in python 3.4. As you want. |
|||
| msg191452 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-06-19 07:31 | |
New changeset 410ea970866e by Serhiy Storchaka in branch '3.3': Issue #18202: Fix minor bugs and cleanup test_coding.py. http://hg.python.org/cpython/rev/410ea970866e New changeset 959f4ce4d590 by Serhiy Storchaka in branch 'default': Issue #18202: Fix minor bugs and cleanup test_source_encoding.py. http://hg.python.org/cpython/rev/959f4ce4d590 |
|||
| msg191453 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-06-19 07:35 | |
Not all other changes are cleanups and enhancements. Some of them also fix minor bugs. Thank you for review Victor. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:46 | admin | set | github: 62402 |
| 2013-06-19 07:35:24 | serhiy.storchaka | set | status: open -> closed messages: + msg191453 assignee: serhiy.storchaka resolution: fixed stage: patch review -> resolved |
| 2013-06-19 07:31:49 | python-dev | set | nosy:
+ python-dev messages: + msg191452 |
| 2013-06-18 22:24:44 | vstinner | set | messages: + msg191438 |
| 2013-06-13 22:58:26 | vstinner | set | nosy:
+ vstinner |
| 2013-06-13 08:04:44 | serhiy.storchaka | set | files: + test_coding.patch |
| 2013-06-13 08:03:49 | serhiy.storchaka | set | files: - test_coding.patch |
| 2013-06-13 08:03:07 | serhiy.storchaka | create | |