➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-05-28 19:16 by hideaki_t, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| diff | hideaki_t, 2013-05-28 19:17 | patch for Python 3.4 | review | |
| 18084.patch | hideaki_t, 2013-05-28 21:37 | patch updated(fix a problem and an enhancement by review) | review | |
| 18084_2.patch | hideaki_t, 2013-05-29 19:59 | adding myself to ACKS | review | |
| Messages (8) | |||
|---|---|---|---|
| msg190235 - (view) | Author: Hideaki Takahashi (hideaki_t) * | Date: 2013-05-28 19:16 | |
wave.py uses struct based endianness detecting code. However there is sys.byteorder in Python since Python 2.0. I think wave.py should use sys.byteorder to determine endianness. |
|||
| msg190243 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2013-05-28 20:10 | |
I have added some comments on Rietveld. |
|||
| msg190290 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-05-29 11:28 | |
Can you please submit a contributor form? http://python.org/psf/contrib/contrib-form/ http://python.org/psf/contrib/ |
|||
| msg190311 - (view) | Author: Hideaki Takahashi (hideaki_t) * | Date: 2013-05-29 14:58 | |
I signed it and by eSign and got a signed/filed response yesterday. But according to Lifecycle of a patch in developer guide, my name is needed to be added to Misc/ACKS. Can I update patch to do this? |
|||
| msg190313 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-05-29 15:33 | |
Yes, please. |
|||
| msg190325 - (view) | Author: Hideaki Takahashi (hideaki_t) * | Date: 2013-05-29 19:59 | |
Patch updated. Thanks. |
|||
| msg190329 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-05-29 20:45 | |
New changeset ccffce2dde49 by Serhiy Storchaka in branch 'default': Issue #18084: Use sys.byteorder in wave.py. http://hg.python.org/cpython/rev/ccffce2dde49 |
|||
| msg190330 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-05-29 21:07 | |
Thank you for your patch. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:46 | admin | set | github: 62284 |
| 2013-05-29 21:07:19 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg190330 stage: patch review -> resolved |
| 2013-05-29 20:45:21 | python-dev | set | nosy:
+ python-dev messages: + msg190329 |
| 2013-05-29 19:59:02 | hideaki_t | set | files:
+ 18084_2.patch messages: + msg190325 |
| 2013-05-29 15:33:02 | serhiy.storchaka | set | messages: + msg190313 |
| 2013-05-29 14:58:51 | hideaki_t | set | messages: + msg190311 |
| 2013-05-29 11:28:04 | serhiy.storchaka | set | messages: + msg190290 |
| 2013-05-28 21:37:40 | hideaki_t | set | files:
+ 18084.patch keywords: + patch |
| 2013-05-28 20:10:47 | serhiy.storchaka | set | versions:
+ Python 3.4 messages: + msg190243 assignee: serhiy.storchaka type: enhancement stage: patch review |
| 2013-05-28 19:41:08 | pitrou | set | nosy:
+ serhiy.storchaka |
| 2013-05-28 19:17:19 | hideaki_t | set | files: + diff |
| 2013-05-28 19:16:19 | hideaki_t | create | |