This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Remove SGI-specific code from pty.py
Type: resource usage Stage: resolved
Components: Library (Lib) Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: akuchling, eric.araujo, python-dev
Priority: normal Keywords:

Created on 2013-05-26 12:32 by akuchling, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
remove-sgi.txt akuchling, 2013-05-26 12:32 review
Messages (3)
msg190083 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2013-05-26 12:32
pty.py contains some code that tries to do 'import sgi' and then does something SGI-specific.  sgimodule.c was dropped in 3.0alpha1, so this code is now useless.

The attached patch removes it; I'm posting the code review largely in case someone wants to suggest changes to the docstring.
msg190409 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2013-05-31 18:53
LGTM.
msg190452 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-06-01 17:54
New changeset a678f139510b by Andrew Kuchling in branch 'default':
#18066: remove vestigial code depending on the sgi module
http://hg.python.org/cpython/rev/a678f139510b
History
Date User Action Args
2022-04-11 14:57:46adminsetgithub: 62266
2013-06-01 17:54:55akuchlingsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2013-06-01 17:54:05python-devsetnosy: + python-dev
messages: + msg190452
2013-05-31 18:53:36eric.araujosetnosy: + eric.araujo
messages: + msg190409
2013-05-26 14:08:40pitrousetcomponents: + Library (Lib)
versions: + Python 3.4
2013-05-26 12:32:17akuchlingcreate