This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Missed comma causes unintentional implicit string literal concatenation
Type: behavior Stage: resolved
Components: Demos and Tools Versions: Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: ezio.melotti, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2013-05-16 07:18 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
missed_comma.patch serhiy.storchaka, 2013-05-16 07:18 review
Messages (4)
msg189343 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-05-16 07:18
I just found a bug in Tools/scripts/abitype.py:

typeslots = [
    'tp_name',
    'tp_basicsize',
    ...
    'tp_subclasses',
    'tp_weaklist',
    'tp_del'
    'tp_version_tag'
]

There is a missed comma after 'tp_del'.

Perhaps there are other similar bugs in Python sources.
msg189344 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-05-16 07:39
Patch LGTM.  Are you planning to look for similar bugs before fixing this?
msg189424 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-05-17 07:19
I haven't found any similar bugs, but I have found other bug in Tools/scripts/abitype.py.
msg189425 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-05-17 07:21
Oh, committed in changesets 26531f21bc4c and 27cc0e0b7637.
History
Date User Action Args
2022-04-11 14:57:45adminsetgithub: 62193
2013-05-17 07:21:30serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg189425

stage: commit review -> resolved
2013-05-17 07:19:36serhiy.storchakasetassignee: serhiy.storchaka
messages: + msg189424
2013-05-16 07:39:22ezio.melottisetnosy: + ezio.melotti

messages: + msg189344
stage: patch review -> commit review
2013-05-16 07:18:52serhiy.storchakacreate