Created on 2013-04-09 13:40 by Wei-Cheng.Pan, last changed 2013-04-09 14:15 by orsenthil. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| cookiejar_fix_deprecated_method_calls.patch | Wei-Cheng.Pan, 2013-04-09 13:46 | correct patch | review | |
| Messages (3) | |||
|---|---|---|---|
| msg186407 - (view) | Author: Wei-Cheng Pan (Wei-Cheng.Pan) * | Date: 2013-04-09 13:46 | |
Please ignore previous typo patch. This is the correct version |
|||
| msg186413 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-04-09 14:11 | |
New changeset b3d5621511db by Senthil Kumaran in branch '3.3': #17678: Fix DeprecationWarning in the http/cookiejar.py by changing the usage http://hg.python.org/cpython/rev/b3d5621511db New changeset 79387f3bcc92 by Senthil Kumaran in branch 'default': #17678: Remove the use of a deprecated method http/cookiejar.py. Changing the http://hg.python.org/cpython/rev/79387f3bcc92 |
|||
| msg186414 - (view) | Author: Senthil Kumaran (orsenthil) *  |
Date: 2013-04-09 14:15 | |
Thanks for the patch. Realized that is_third_party method does not have test coverage. Hence this was not detected by our test runs. Increasing the coverage may be a TODO. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-04-09 14:15:56 | orsenthil | set | status: open -> closed type: behavior assignee: orsenthil nosy: + orsenthil messages: + msg186414 resolution: fixed stage: resolved |
| 2013-04-09 14:11:17 | python-dev | set | nosy:
+ python-dev messages: + msg186413 |
| 2013-04-09 13:46:49 | Wei-Cheng.Pan | set | files: - cookiejar_fix_deprecated_method_calls.patch |
| 2013-04-09 13:46:40 | Wei-Cheng.Pan | set | files:
+ cookiejar_fix_deprecated_method_calls.patch messages: + msg186407 |
| 2013-04-09 13:40:04 | Wei-Cheng.Pan | create | |