➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-04-08 12:57 by bkabrda, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| python-2.7.4-properly-compile-socketmodule-by-Setupdist.patch | bkabrda, 2013-04-08 12:57 | review | ||
| Messages (3) | |||
|---|---|---|---|
| msg186298 - (view) | Author: Bohuslav "Slavek" Kabrda (bkabrda) * | Date: 2013-04-08 12:57 | |
When building extension modules of Python 2.7.4 through Modules/Setup.dist, the socketmodule gets built badly, as it also needs to be compiled with timemodule.c (see the attached patch). This was caused by commit 8ec39bfd1f01, which introduced usage of _PyTime_floattime() without fixing Setup.dist (note, that this is ok when compiling through setup.py, as it has: exts.append( Extension('_socket', ['socketmodule.c', 'timemodule.c'], |
|||
| msg186309 - (view) | Author: Kristján Valur Jónsson (kristjan.jonsson) *  |
Date: 2013-04-08 15:28 | |
This is my fault, I admit to not being an expert in non-windows builds. I've no idea how Modules/Setup.dist works but the patch looks reasonable and if it works, then all is fine. |
|||
| msg186315 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-04-08 16:04 | |
New changeset bad85e4e6b7f by Kristjan Valur Jonsson in branch '2.7': Issue #17662: fix socketmodule compilation with Setup.dist. http://hg.python.org/cpython/rev/bad85e4e6b7f |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:44 | admin | set | github: 61862 |
| 2013-04-08 16:04:41 | kristjan.jonsson | set | status: open -> closed resolution: fixed |
| 2013-04-08 16:04:01 | python-dev | set | nosy:
+ python-dev messages: + msg186315 |
| 2013-04-08 15:28:32 | kristjan.jonsson | set | messages: + msg186309 |
| 2013-04-08 15:25:01 | pitrou | set | nosy:
+ kristjan.jonsson |
| 2013-04-08 12:57:16 | bkabrda | create | |