Created on 2013-04-08 03:37 by Todd.Rovito, last changed 2013-04-09 02:12 by roger.serwy. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 17657IDLEAboutDialogReportFullVersionOfTK.patch | Todd.Rovito, 2013-04-08 03:42 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg186266 - (view) | Author: Todd Rovito (Todd.Rovito) * | Date: 2013-04-08 03:37 | |
The IDLE about dialog does not report the full version of TK. For instance it will report "8.5" and not report the last minor version number such as "8.5.9". On the Mac OS X this is problematic (but it could be a problem on other platforms) because Apple ships their own version of TK which is known to be buggy. For bug reporting purposes IDLE should report the full version of TK which could help diagnose bugs. |
|||
| msg186267 - (view) | Author: Todd Rovito (Todd.Rovito) * | Date: 2013-04-08 03:42 | |
Attached is a patch the works for both Python 3.4 and Python 2.7. I have tested this patch on OS X and Windows. The code actually came from macosxSupport.py function tkVersionWarning. |
|||
| msg186271 - (view) | Author: Roger Serwy (roger.serwy) *  |
Date: 2013-04-08 04:07 | |
LGTM. The patch works on Arch Linux, returning 8.5.13 which is what I have installed. |
|||
| msg186277 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2013-04-08 05:29 | |
At some point, I would like us to review the whole 'about' dialog, but this should be done now. It even simplifies the code. I will test and apply this week if Roger doesn't. |
|||
| msg186278 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2013-04-08 05:39 | |
LGTM |
|||
| msg186366 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-04-09 02:00 | |
New changeset 9b6de25c6054 by Roger Serwy in branch '2.7': #17657: Show full Tk version in IDLE's about dialog. http://hg.python.org/cpython/rev/9b6de25c6054 New changeset 769699f0a760 by Roger Serwy in branch '3.3': #17657: Show full Tk version in IDLE's about dialog. http://hg.python.org/cpython/rev/769699f0a760 New changeset 50164abbfc98 by Roger Serwy in branch 'default': #17657: merge with 3.3. http://hg.python.org/cpython/rev/50164abbfc98 |
|||
| msg186368 - (view) | Author: Roger Serwy (roger.serwy) * |
Date: 2013-04-09 02:12 | |
Let's discuss improving the about dialog on idle-dev or in a new issue. Thanks for the patch, Todd! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-04-09 02:12:54 | roger.serwy | set | status: open -> closed resolution: fixed messages: + msg186368 stage: commit review -> resolved |
| 2013-04-09 02:00:20 | python-dev | set | nosy:
+ python-dev messages: + msg186366 |
| 2013-04-08 05:39:29 | ned.deily | set | messages: + msg186278 |
| 2013-04-08 05:29:05 | terry.reedy | set | messages:
+ msg186277 stage: patch review -> commit review |
| 2013-04-08 04:07:41 | roger.serwy | set | type: behavior -> enhancement stage: patch review messages: + msg186271 versions: + Python 3.3 |
| 2013-04-08 03:43:07 | Todd.Rovito | set | nosy:
+ terry.reedy, ned.deily, roger.serwy |
| 2013-04-08 03:42:28 | Todd.Rovito | set | files:
+ 17657IDLEAboutDialogReportFullVersionOfTK.patch keywords: + patch messages: + msg186267 |
| 2013-04-08 03:37:34 | Todd.Rovito | create | |