This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_urllib2 convert doctests to unittest
Type: behavior Stage: resolved
Components: Versions: Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: orsenthil Nosy List: eric.araujo, ezio.melotti, orsenthil, python-dev, r.david.murray
Priority: normal Keywords: patch

Created on 2013-04-06 23:45 by orsenthil, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
remove_doctests.patch orsenthil, 2013-04-06 23:45 review
Messages (5)
msg186171 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2013-04-06 23:45
Sometime back during an IRC conversation we realized that converting test_urllib2 doctests to proper unittest may help in various ways. 
a) Improve coverage report (?) Know what is covered and not.
b) Helps expand it further when new features are added.

Here is patch which removes the old doctests and converts them to unittest.

Reviews will be helpful.
msg186375 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-04-09 05:24
New changeset eb632aafff57 by Senthil Kumaran in branch 'default':
#17648 - Clean up test_urllib2.py. Converted doctests to unittest for
http://hg.python.org/cpython/rev/eb632aafff57
msg186376 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2013-04-09 05:26
I have pushed the changes since they are restricted to test files. If there are review comments, I shall do make the changes. 

I shall consider to to make 3.3 tests close to default branch ones so that fixes can be backported. (Leaving the bug open for that).
msg186395 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-04-09 13:01
New changeset 5c9b36969abc by Senthil Kumaran in branch '3.3':
#17648 - convert test_urllib2.py doctests to unittests
http://hg.python.org/cpython/rev/5c9b36969abc
msg186396 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2013-04-09 13:03
Changed in active branches (3.3 and default).
History
Date User Action Args
2022-04-11 14:57:43adminsetgithub: 61848
2013-04-09 13:03:45orsenthilsetversions: + Python 3.3
2013-04-09 13:03:30orsenthilsetstatus: open -> closed

messages: + msg186396
2013-04-09 13:01:25python-devsetmessages: + msg186395
2013-04-09 05:26:38orsenthilsettype: behavior
resolution: fixed
messages: + msg186376
stage: resolved
2013-04-09 05:24:27python-devsetnosy: + python-dev
messages: + msg186375
2013-04-06 23:45:14orsenthilcreate