➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-04-01 22:00 by eric.smith, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Messages (3) | |||
|---|---|---|---|
| msg185777 - (view) | Author: Eric V. Smith (eric.smith) *  |
Date: 2013-04-01 22:00 | |
In the mail hook, there's a comment that says:
'''
To set the SMTP server to something other than localhost, add a [smtp]
section to your hgrc:
[smtp]
host = mail.python.org
port = 25
'''
This is not true. The default host is '', which tells smtplib.SMTP to not make an initial connection. If we want the comment to be correct, then we need to set 'localhost' as the default:
- host = ui.config('smtp', 'host', '')
+ host = ui.config('smtp', 'host', 'localhost')
I guess there's some chance that we want to force the smtp host to be set. If that's the case then then comment should be changed and the code modified to require the host be specified in the config file (or at least a better error message than 'please run connect() first').
Adding Antoine because annotate points to him for these lines.
|
|||
| msg185833 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2013-04-02 12:39 | |
Well, mercurial itself requires the presence of a "host" item in "[smtp]", so it would make sense to require it too. |
|||
| msg382580 - (view) | Author: Irit Katriel (iritkatriel) * |
Date: 2020-12-05 18:36 | |
This seems out of date (pre github?) I couldn't find that comment in the current codebase. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:43 | admin | set | github: 61812 |
| 2020-12-06 00:29:31 | eric.smith | set | status: pending -> closed resolution: out of date stage: resolved |
| 2020-12-05 18:36:13 | iritkatriel | set | status: open -> pending nosy: + iritkatriel messages: + msg382580 |
| 2013-04-02 12:39:18 | pitrou | set | nosy:
+ ezio.melotti messages: + msg185833 |
| 2013-04-01 22:00:55 | eric.smith | create | |