classification
Title: pyexpat unit tests - str/uni branch
Type: Stage:
Components: Tests Versions: Python 3.0
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, jcgregorio
Priority: normal Keywords: patch

Created on 2007-07-23 16:23 by jcgregorio, last changed 2008-01-06 22:29 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
pyexpat.diff jcgregorio, 2007-07-23 16:23 patch for test_pyexpat.py and pyexpat.c
pyexpat.2.diff jcgregorio, 2007-07-23 17:21 new patch after svn up
Messages (5)
msg52933 - (view) Author: Joe Gregorio (jcgregorio) * Date: 2007-07-23 16:23 
Fixes to module and unit tests so that unit tests pass.
Changes:

1. Removed "returns_unicode" attribute, associated code
   in the module to support that attribute, and all tests
   associated with it.
2. Parsed data is now returned as unicode strings.
3. Changed input tests to use io.BytesIO instead
   of StringIO, to reflect the byte processing
   nature of expat.
msg52934 - (view) Author: Joe Gregorio (jcgregorio) * Date: 2007-07-23 16:35 
Discussion of only processing bytes:

  http://mail.python.org/pipermail/python-3000/2007-July/008861.html

Discussion of removing 'returns_unicode':

  http://mail.python.org/pipermail/python-3000/2007-July/008895.html
msg52935 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-07-23 17:00 
When trying to apply the patch I get:

Hunk #14 FAILED at 878.
1 out of 21 hunks FAILED -- saving rejects to file Modules/pyexpat.c.rej

Can you svn up, fix the patch, and upload it again?
msg52936 - (view) Author: Joe Gregorio (jcgregorio) * Date: 2007-07-23 17:21 
Sorry about that.

Here is a new patch after updating to the latest svn.

This one also contains the updates to the Docs. Let me
know if you want me to drop that from the patch.
File Added: pyexpat.2.diff
msg52937 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-07-23 17:42 
Committed revision 56512.
History
Date User Action Args
2008-01-06 22:29:45adminsetkeywords: - py3k
versions: + Python 3.0
2007-07-23 16:23:54jcgregoriocreate