classification
Title: --enable-profiling does nothing (shell syntax bug in configure.ac)
Type: behavior Stage: resolved
Components: Versions: Python 3.4, Python 3.3, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, georg.brandl, gergo, python-dev
Priority: normal Keywords: patch

Created on 2013-03-26 12:12 by gergo, last changed 2013-04-06 14:43 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
enable-profiling.patch gergo, 2013-03-26 12:12 patch review
Messages (5)
msg185269 - (view) Author: Gergö Barany (gergo) Date: 2013-03-26 12:12
Trying to configure Python (3.3 and 3.4 prerelease from Mercurial) with --enable-profiling doesn't work because the configure script contains a syntax error that causes it to conclude that the C compiler does not accept the -pg flag:

$ ../cpython/configure --enable-profiling | grep prof
configure: WARNING:

  By default, distutils will build C++ extension modules with "g++".
  If this is not intended, then set CXX on the configure command line.
  
../cpython/configure: line 5537: CC: command not found
checking for --enable-profiling... no

Everything (configure/build/running Python) continues as if --enable-profiling had not been passed.

This is due to using $(CC) rather than the correct syntax $CC at the specified place in the configure script. The attached patch to configure.ac fixes this.
msg185270 - (view) Author: Roundup Robot (python-dev) Date: 2013-03-26 12:58
New changeset 27cb49ede303 by Benjamin Peterson in branch '2.7':
fix variable reference to fix --enable-profiling (closes #17550)
http://hg.python.org/cpython/rev/27cb49ede303

New changeset d321885ff8f3 by Benjamin Peterson in branch '2.7':
merge 2.7.4 release branch (#17550)
http://hg.python.org/cpython/rev/d321885ff8f3

New changeset 0decf2a812df by Benjamin Peterson in branch '3.3':
fix variable reference to fix --enable-profiling (closes #17550)
http://hg.python.org/cpython/rev/0decf2a812df

New changeset 81e005a410b7 by Benjamin Peterson in branch 'default':
merge 3.3 (#17550)
http://hg.python.org/cpython/rev/81e005a410b7
msg185271 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2013-03-26 12:59
Georg, I fixed this in the 2.7.4 release branch. You might want to in 3.3, too.
msg185272 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2013-03-26 13:04
Done, thanks for the pointer!
msg186129 - (view) Author: Roundup Robot (python-dev) Date: 2013-04-06 14:43
New changeset 2ab2a09901f9 by Georg Brandl in branch '3.3':
fix variable reference to fix --enable-profiling (closes #17550)
http://hg.python.org/cpython/rev/2ab2a09901f9
History
Date User Action Args
2013-04-06 14:43:59python-devsetmessages: + msg186129
stage: resolved
2013-03-26 13:04:37georg.brandlsetmessages: + msg185272
2013-03-26 13:00:00benjamin.petersonsetstatus: open -> closed
resolution: fixed
2013-03-26 12:59:49benjamin.petersonsetstatus: closed -> open

versions: + Python 2.7
nosy: + georg.brandl, benjamin.peterson

messages: + msg185271
resolution: fixed -> (no value)
stage: resolved -> (no value)
2013-03-26 12:58:29python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg185270

resolution: fixed
stage: resolved
2013-03-26 12:12:16gergocreate