classification
Title: Patch for Windows build
Type: Stage:
Components: Build Versions: Python 3.0
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, theller (2)
Priority: normal Keywords: patch

Created on 2007-07-11 10:51 by theller, last changed 2008-01-06 22:29 by admin.

Files
File name Uploaded Description Edit Remove
windows.diff theller, 2007-07-11 10:51 Patches for windows
Messages (3)
msg52830 - (view) Author: Thomas Heller (theller) Date: 2007-07-11 10:51 
In Modules/_fileio.c, HAVE_FTRUNCATE is undefined for Windows.
msg52831 - (view) Author: Guido van Rossum (gvanrossum) Date: 2007-07-11 12:33 
Looks fine. Can you check this in yourself?

Nit: I note that the line added for _fileio to PC/config.c is improperly indented (space/tab issue?).

Note that this will make various tests using f.truncate() fail.  At some point we need to implement it using the same APIs as were used in the old file object.

Also, my hope is that eventually we'll have a Windows specific version of _fileio.c instead of this code, using all-native Windows API calls.  (Any volunteers?)
msg52832 - (view) Author: Thomas Heller (theller) Date: 2007-07-11 12:47 
Committed as SVN rev. 56264, after fixing the indentation of the added lines in config.c.
Note that config.c is indented partly with tabs, partly with spaces anyway.
History
Date User Action Args
2008-01-06 22:29:45adminsetkeywords: - py3k
versions: + Python 3.0
2007-07-11 10:51:03thellercreate