➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-03-06 07:06 by berker.peksag, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_print.diff | berker.peksag, 2013-03-06 07:06 | review | ||
| test_print_v2.diff | berker.peksag, 2013-04-04 19:21 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg183581 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2013-03-06 07:06 | |
Changes: * Removed Python 2 specific code * Re-enabled u'' tests (see PEP 414) * Cosmetic fixes |
|||
| msg183785 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2013-03-09 03:21 | |
In 3.3+ the u prefix is ignored in the lexer stage and I am sure that is tested in the string literal syntax tests. It has nothing to do with printing. The commented out tests you appropriately removed were testing the printing of unicode instead of byte strings. |
|||
| msg183898 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2013-03-10 21:01 | |
Agree with Terry. The patch LGTM except unicode literals part. |
|||
| msg183922 - (view) | Author: Éric Araujo (eric.araujo) * |
Date: 2013-03-11 04:28 | |
The cosmetic changes to whitespace and parens seem like diff noise to me. |
|||
| msg186048 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2013-04-04 19:21 | |
Thanks for the reviews. Patch updated. Éric, since the test file is relatively small, I went ahead and made some cosmetic fixes, but I can open a new issue for them :) |
|||
| msg186050 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-04-04 19:32 | |
New changeset 178075fbff3a by Andrew Svetlov in branch 'default': #17365: Remove Python 2 code from test_print http://hg.python.org/cpython/rev/178075fbff3a |
|||
| msg186051 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2013-04-04 19:33 | |
Fixed. Thanks, Berker |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:42 | admin | set | github: 61567 |
| 2013-04-04 19:33:15 | asvetlov | set | status: open -> closed resolution: fixed messages: + msg186051 stage: patch review -> resolved |
| 2013-04-04 19:32:39 | python-dev | set | nosy:
+ python-dev messages: + msg186050 |
| 2013-04-04 19:21:36 | berker.peksag | set | files:
+ test_print_v2.diff messages: + msg186048 |
| 2013-03-11 04:28:50 | eric.araujo | set | nosy:
+ eric.araujo messages: + msg183922 |
| 2013-03-10 21:01:47 | asvetlov | set | nosy:
+ asvetlov messages: + msg183898 |
| 2013-03-09 03:21:51 | terry.reedy | set | nosy:
+ ezio.melotti, terry.reedy, michael.foord, pitrou messages: + msg183785 type: enhancement stage: patch review |
| 2013-03-06 07:06:33 | berker.peksag | create | |