This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Pickle tests do not test protocols 0, 1, and 2 for bytes
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.2, Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: ezio.melotti, mgedmin, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2013-03-04 09:45 by mgedmin, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
actually-test-all-protocols.diff mgedmin, 2013-03-04 09:45 patch to test all protocols in test_bytes review
Messages (4)
msg183429 - (view) Author: Marius Gedminas (mgedmin) * Date: 2013-03-04 09:45
I was reading Lib/test/pickletester.py when I noticed that test_bytes loops over all the protocols but doesn't actually use the loop variable anywhere.

Attached patch should fix this.
msg183438 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-03-04 12:29
LGTM.
msg183448 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-03-04 13:23
New changeset a982feb29584 by Ezio Melotti in branch '3.2':
#17346: make sure pickle tests are run against all protocols.  Initial patch by Marius Gedminas.
http://hg.python.org/cpython/rev/a982feb29584

New changeset 796de4f7df07 by Ezio Melotti in branch '3.3':
#17346: merge with 3.2.
http://hg.python.org/cpython/rev/796de4f7df07

New changeset 5c8a5cfe25b0 by Ezio Melotti in branch 'default':
#17346: merge with 3.3.
http://hg.python.org/cpython/rev/5c8a5cfe25b0

New changeset 654136546895 by Ezio Melotti in branch '2.7':
#17346: make sure pickle tests are run against all protocols.
http://hg.python.org/cpython/rev/654136546895
msg183449 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-03-04 13:24
Fixed, thanks for the report and the patch!
History
Date User Action Args
2022-04-11 14:57:42adminsetgithub: 61548
2013-03-04 13:24:04ezio.melottisetstatus: open -> closed
messages: + msg183449

assignee: ezio.melotti
resolution: fixed
stage: patch review -> resolved
2013-03-04 13:23:26python-devsetnosy: + python-dev
messages: + msg183448
2013-03-04 12:29:50serhiy.storchakasetnosy: + serhiy.storchaka

messages: + msg183438
versions: + Python 3.2, Python 3.4
2013-03-04 10:17:33ezio.melottisetnosy: + ezio.melotti

stage: patch review
2013-03-04 09:45:52mgedmincreate