➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-02-27 20:11 by brett.cannon, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| benchmark_count.patch | anuj, 2013-03-10 01:48 | |||
| count_benchmarks.diff | brett.cannon, 2013-03-10 14:57 | |||
| benchmark_counts.patch | anuj, 2013-03-10 16:37 | |||
| Messages (11) | |||
|---|---|---|---|
| msg183183 - (view) | Author: Brett Cannon (brett.cannon) *  |
Date: 2013-02-27 20:11 | |
E.g. when you run ``./perf.py -h`` it lists the py3k benchmark target as having 4 benchmarks, but that's wrong since the 2n3 benchmark alone (which py3k includes) has 23 benchmarks. |
|||
| msg183859 - (view) | Author: Anuj Gupta (anuj) * | Date: 2013-03-10 01:48 | |
Fixed ( My first contribution ever, please be kind :) ) |
|||
| msg183878 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2013-03-10 14:57 | |
Thanks for the patch, Anuj! The solution looks fine. While reviewing I discovered the test suite didn't work anymore and so I fixed that plus added a test to the name expansion to make sure it would always work properly. All of that is included in the patch I uploaded. Could you sign the CLA at http://www.python.org/psf/contrib/contrib-form/ and then ping this bug once you have? When that is done then I can commit our combined patch. |
|||
| msg183881 - (view) | Author: Anuj Gupta (anuj) * | Date: 2013-03-10 16:18 | |
I've already signed that. I was contemplating adding my name to the Misc/ACK file but I'd like to know if it's appropriate. Certainly gives one a confidence boost, but I'm not aware whether this fix qualifies me for it. I'd like to contribute a lot more code to Python. Could you guide me a little for that please? Thanks |
|||
| msg183883 - (view) | Author: Anuj Gupta (anuj) * | Date: 2013-03-10 16:37 | |
Improved wording of the comment |
|||
| msg183887 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2013-03-10 17:37 | |
How and when did you sign the CLA? It has not been registered yet that you have, else your username would have an asterisk next to it. As for Misc/ACKS, that's in Python itself and not the benchmark suite so this wouldn't get you in that file. To contribute more, make sure to read the devguide at http://docs.python.org/devguide/ |
|||
| msg183888 - (view) | Author: Anuj Gupta (anuj) * | Date: 2013-03-10 17:45 | |
I did it yesterday while studying the devguide and "how to get started" articles. Just did it again, and received an email with the subject "The Python Contributor Agreement Form (between Anuj Gupta and Python Software Foundation) is Signed and Filed!". Still no asterisk :( |
|||
| msg183889 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2013-03-10 17:49 | |
The asterisk is added manually by a person, so by virtue of it being a weekend no one has gotten to it yet. As soon as it has been processed and I have time I will commit the patch. |
|||
| msg184749 - (view) | Author: Anuj Gupta (anuj) * | Date: 2013-03-20 10:04 | |
The asterisk is visible now, Brett :) Please commit the patch at your convenience. |
|||
| msg185236 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-03-25 21:29 | |
New changeset 3be9e07a2df4 by Brett Cannon in branch 'default': Issue #17317: Have the benchmark count from -h properly reflect the http://hg.python.org/benchmarks/rev/3be9e07a2df4 |
|||
| msg185237 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2013-03-25 21:29 | |
Thanks for being so patient, Anuj! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:42 | admin | set | github: 61519 |
| 2013-03-25 21:29:59 | brett.cannon | set | status: open -> closed resolution: fixed messages: + msg185237 |
| 2013-03-25 21:29:31 | python-dev | set | nosy:
+ python-dev messages: + msg185236 |
| 2013-03-20 10:04:50 | anuj | set | messages: + msg184749 |
| 2013-03-10 17:49:20 | brett.cannon | set | messages: + msg183889 |
| 2013-03-10 17:45:56 | anuj | set | messages: + msg183888 |
| 2013-03-10 17:37:41 | brett.cannon | set | messages: + msg183887 |
| 2013-03-10 16:37:18 | anuj | set | files:
+ benchmark_counts.patch messages: + msg183883 |
| 2013-03-10 16:18:36 | anuj | set | messages: + msg183881 |
| 2013-03-10 14:57:21 | brett.cannon | set | files:
+ count_benchmarks.diff messages: + msg183878 assignee: brett.cannon components: + Benchmarks stage: commit review |
| 2013-03-10 01:48:34 | anuj | set | files:
+ benchmark_count.patch nosy: + anuj messages: + msg183859 keywords: + patch type: behavior |
| 2013-02-27 20:11:39 | brett.cannon | create | |