Created on 2013-01-12 14:54 by haypo, last changed 2013-01-29 15:17 by haypo.
| Messages (2) | |||
|---|---|---|---|
| msg179803 - (view) | Author: STINNER Victor (haypo) *  |
Date: 2013-01-12 14:54 | |
The following extract of _close_open_fd_range_safe() is not correct:
#ifdef O_CLOEXEC
fd_dir_fd = open(FD_DIR, O_RDONLY | O_CLOEXEC, 0);
#else
fd_dir_fd = open(FD_DIR, O_RDONLY, 0);
#ifdef FD_CLOEXEC
{
int old = fcntl(fd_dir_fd, F_GETFD);
if (old != -1)
fcntl(fd_dir_fd, F_SETFD, old | FD_CLOEXEC);
}
#endif
#endif
On Linux older than 2.6.23, O_CLOEXEC may be defined by the glibc whereas the kernel does not support it. In this case, the flag is simply ignored and close-on-exec flag is not set on the file descriptor.
|
|||
| msg180910 - (view) | Author: STINNER Victor (haypo) * |
Date: 2013-01-29 15:17 | |
This issue is fixed in my implementation of the PEP 433: see #17036. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-01-29 15:17:03 | haypo | set | messages: + msg180910 |
| 2013-01-13 07:07:07 | gregory.p.smith | set | assignee: gregory.p.smith nosy: + gregory.p.smith, - gps |
| 2013-01-12 15:10:33 | r.david.murray | set | nosy:
+ gps |
| 2013-01-12 14:54:13 | haypo | create | |