classification
Title: Fix test discovery for test_crypt.py
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.4, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: brett.cannon, ezio.melotti, python-dev, zach.ware
Priority: normal Keywords: patch

Created on 2013-01-10 16:51 by zach.ware, last changed 2013-01-11 03:32 by zach.ware. This issue is now closed.

Files
File name Uploaded Description Edit
test_crypt_discovery.diff zach.ware, 2013-01-10 16:51 test_crypt.py fix, version 1 review
Messages (4)
msg179572 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-01-10 16:51
Here's a fix for test_crypt.py, inspired by Ezio's mention of using setUpModule in issue 16905.

I can't test this on a platform that actually has _crypt at the moment, but I should be able to later today if nobody else has before then.  Some tinkering has shown me that it /should/ work, though.
msg179617 - (view) Author: Roundup Robot (python-dev) Date: 2013-01-11 03:20
New changeset 15ddd683c321 by Ezio Melotti in branch '3.3':
#16919: test_crypt now works with unittest test discovery. Patch by Zachary Ware.
http://hg.python.org/cpython/rev/15ddd683c321

New changeset 5345f515e03b by Ezio Melotti in branch 'default':
#16919: merge with 3.3.
http://hg.python.org/cpython/rev/5345f515e03b
msg179618 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-01-11 03:22
Fixed, thanks for the patch!
I tested it with and without crypt and with and without test discovery and all the combinations seem to work fine.
msg179619 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-01-11 03:32
I was just about to test it at home and couldn't find it in my list of open issues.

Thanks, Ezio :)
History
Date User Action Args
2013-01-11 03:32:10zach.waresetmessages: + msg179619
2013-01-11 03:22:13ezio.melottisetstatus: open -> closed
resolution: fixed
messages: + msg179618

stage: patch review -> resolved
2013-01-11 03:20:21python-devsetnosy: + python-dev
messages: + msg179617
2013-01-10 16:58:07ezio.melottisetassignee: ezio.melotti
stage: patch review
2013-01-10 16:51:23zach.warecreate