classification
Title: Update JSON tests
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.4, Python 3.2, Python 3.3, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: ezio.melotti, pitrou, python-dev, rhettinger, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2012-11-26 15:40 by serhiy.storchaka, last changed 2012-11-26 19:48 by pitrou. This issue is now closed.

Files
File name Uploaded Description Edit
json_tests_2.patch serhiy.storchaka, 2012-11-26 17:07 review
Messages (5)
msg176421 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-11-26 15:40
The json module tests contain testcases from the official testsuite (http://json.org/JSON_checker/test.zip). At the moment these testcases differ slightly and the proposed patch updates testcases to conform with the current official testsuite (which was changed 2007-10-05 last time).

I think tests updating can be applied to old Python versions.
msg176426 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-11-26 17:00
Tests used distorted official testcases for testing non-standard Python json module features. Now it is extracted in separate tests.
msg176427 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-11-26 17:07
Oops. I attached patch for other issue. Here is a right one.
msg176430 - (view) Author: Roundup Robot (python-dev) Date: 2012-11-26 17:28
New changeset e092ff374721 by Ezio Melotti in branch '2.7':
#16559: Add more tests for the json module.  Patch by Serhiy Storchaka.
http://hg.python.org/cpython/rev/e092ff374721

New changeset 4f21a9b7decf by Ezio Melotti in branch '3.2':
#16559: Add more tests for the json module.  Patch by Serhiy Storchaka.
http://hg.python.org/cpython/rev/4f21a9b7decf

New changeset 139a8cbca94e by Ezio Melotti in branch '3.3':
#16559: merge with 3.2.
http://hg.python.org/cpython/rev/139a8cbca94e

New changeset a5b3eb62311e by Ezio Melotti in branch 'default':
#16559: merge with 3.3.
http://hg.python.org/cpython/rev/a5b3eb62311e
msg176447 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-11-26 19:48
It's always nice to see more tests, thank you!
History
Date User Action Args
2012-11-26 19:48:27pitrousetmessages: + msg176447
2012-11-26 17:47:31serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2012-11-26 17:28:10python-devsetnosy: + python-dev
messages: + msg176430
2012-11-26 17:07:50serhiy.storchakasetfiles: - json_tool_tests_2.patch
2012-11-26 17:07:40serhiy.storchakasetfiles: + json_tests_2.patch

messages: + msg176427
2012-11-26 17:04:43serhiy.storchakasetfiles: - json_tests.patch
2012-11-26 17:00:40serhiy.storchakasetfiles: + json_tool_tests_2.patch

messages: + msg176426
2012-11-26 16:47:18ezio.melottisetassignee: ezio.melotti
2012-11-26 15:40:14serhiy.storchakacreate