➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012-11-08 15:26 by cjw296, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| gzip.py.patch | cjw296, 2012-11-08 16:55 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg175176 - (view) | Author: Chris Withers (cjw296) *  |
Date: 2012-11-08 15:26 | |
gzip.py uses range instead of xrange in two places. This results in excessive memory usage when opening large .gz files. I actually bumped into this using tarfile. Am I right in thinking that range basically *is* xrange in 3.x? If so, this bug applies only to 2.6 and 2.7. |
|||
| msg175181 - (view) | Author: Jesús Cea Avión (jcea) * |
Date: 2012-11-08 16:14 | |
Yes, "range()" in python 3 is equivalent to python 2 "xrange()". 2.6 is in "security only" fix mode. So, you only need to fix 2.7. |
|||
| msg175184 - (view) | Author: Chris Withers (cjw296) * |
Date: 2012-11-08 16:55 | |
Okay, here's the patch. I can't imagine any unit tests are needed or will be impacted by this. I do have commit rights, am I good to commit this? |
|||
| msg175186 - (view) | Author: Nadeem Vawda (nadeem.vawda) * |
Date: 2012-11-08 19:21 | |
Looks good to me. Go ahead. You needn't add or change any tests for this, but you should run the existing tests before committing, just to be safe. |
|||
| msg175195 - (view) | Author: Ezio Melotti (ezio.melotti) * |
Date: 2012-11-08 22:07 | |
Also remember to add a Misc/NEWS entry (and/or run `make patchcheck`) before committing. If this only affects 2.7 there's no need to merge anything with 3.x, so you can just commit on 2.7 and push. |
|||
| msg175243 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2012-11-09 15:54 | |
New changeset f938d478359a by Chris Withers in branch '2.7': Bug #16441: avoid excessive memory usage working with large gzip files http://hg.python.org/cpython/rev/f938d478359a |
|||
| msg175245 - (view) | Author: Chris Withers (cjw296) * |
Date: 2012-11-09 15:59 | |
Committed on 2.7 branch. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:38 | admin | set | github: 60645 |
| 2012-11-13 05:12:09 | ezio.melotti | set | resolution: fixed |
| 2012-11-09 15:59:44 | cjw296 | set | status: open -> closed messages: + msg175245 stage: patch review -> resolved |
| 2012-11-09 15:54:54 | python-dev | set | nosy:
+ python-dev messages: + msg175243 |
| 2012-11-08 22:07:32 | ezio.melotti | set | nosy:
+ ezio.melotti messages: + msg175195 |
| 2012-11-08 19:21:01 | nadeem.vawda | set | nosy:
+ nadeem.vawda messages: + msg175186 |
| 2012-11-08 16:55:06 | cjw296 | set | files:
+ gzip.py.patch keywords: + patch messages: + msg175184 stage: needs patch -> patch review |
| 2012-11-08 16:17:58 | jcea | set | versions: - Python 2.6 |
| 2012-11-08 16:14:17 | jcea | set | nosy:
+ jcea messages: + msg175181 |
| 2012-11-08 15:26:23 | cjw296 | create | |