classification
Title: Fix for #1601399 (urllib2 does not close sockets properly)
Type: Stage:
Components: Library (Lib) Versions: Python 2.6
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: georg.brandl, jjlee, mark-roberts (3)
Priority: normal Keywords patch

Created on 2007-01-03 23:46 by jjlee, last changed 2007-01-21 10:35 by georg.brandl.

Files
File name Uploaded Description Edit Remove
urllib2_close_socket.patch jjlee, 2007-01-03 23:46
urllib2_close_socket_v2.patch jjlee, 2007-01-21 00:08 with tests added
Messages (5)
msg51643 - (view) Author: John J Lee (jjlee) Date: 2007-01-03 23:46 
Fix for #1601399

Definitely a backport candidate.
msg51644 - (view) Author: Mark Roberts (mark-roberts) Date: 2007-01-20 02:44 
Patch looks good to me, and the tests still pass.  If it matters, I would like to see a test case presented in the patch as well.
msg51645 - (view) Author: John J Lee (jjlee) Date: 2007-01-21 00:08 
Added tests.
File Added: urllib2_close_socket_v2.patch
msg51646 - (view) Author: Mark Roberts (mark-roberts) Date: 2007-01-21 05:26 
I'd say it looks good.  Now lets see if we can get someone to apply it for us.  Thanks for the adding the tests!
msg51647 - (view) Author: Georg Brandl (georg.brandl) Date: 2007-01-21 10:35 
Committed as rev. 53511, 53512 (2.5).
History
Date User Action Args
2007-01-03 23:46:06jjleecreate