This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: missing tests for {RawIO,BufferedIO,TextIO}.writelines
Type: behavior Stage: resolved
Components: IO, Tests Versions: Python 3.2, Python 3.3, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ainur0160, benjamin.peterson, felipecruz, hynek, kyle.roberts, pitrou, python-dev, stutzbach
Priority: normal Keywords: easy, patch

Created on 2012-08-20 22:05 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue15744_v1.patch felipecruz, 2012-09-16 02:24 review
issue15744_v2.patch felipecruz, 2012-09-18 20:29 review
Messages (6)
msg168709 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-08-20 22:05
The writelines() method of I/O objects has almost no tests in test_fileio / test_io (and a couple of them in test_file).
msg170543 - (view) Author: Felipe Cruz (felipecruz) * Date: 2012-09-16 02:24
Add tests for {RawIO,BufferedIO,TextIO}.writelines()
msg170674 - (view) Author: Felipe Cruz (felipecruz) * Date: 2012-09-18 20:29
Updated based on Pitrou comments
msg173096 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-10-16 21:08
New changeset 4c204a61bd79 by Antoine Pitrou in branch '3.2':
Also add tests for TextIOWrapper.writelines() (issue #15744).
http://hg.python.org/cpython/rev/4c204a61bd79

New changeset 2efcaec45697 by Antoine Pitrou in branch '3.3':
Merge for issue #15744: add tests for the writelines() method of file objects.
http://hg.python.org/cpython/rev/2efcaec45697

New changeset e526d67016f0 by Antoine Pitrou in branch 'default':
Merge for issue #15744: add tests for the writelines() method of file objects.
http://hg.python.org/cpython/rev/e526d67016f0
msg173097 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-10-16 21:14
New changeset 5b062bb56037 by Antoine Pitrou in branch '2.7':
Also add tests for TextIOWrapper.writelines() (issue #15744).
http://hg.python.org/cpython/rev/5b062bb56037
msg173098 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-10-16 21:16
I've committed a modified version of your patch. Thank you !
History
Date User Action Args
2022-04-11 14:57:34adminsetgithub: 59949
2012-10-16 21:16:03pitrousetstatus: open -> closed
resolution: fixed
messages: + msg173098

stage: patch review -> resolved
2012-10-16 21:14:58python-devsetmessages: + msg173097
2012-10-16 21:08:15python-devsetnosy: + python-dev
messages: + msg173096
2012-10-16 20:52:44pitrousetstage: needs patch -> patch review
versions: + Python 3.4
2012-09-18 20:29:30felipecruzsetfiles: + issue15744_v2.patch

messages: + msg170674
2012-09-16 02:24:35felipecruzsetfiles: + issue15744_v1.patch

nosy: + felipecruz
messages: + msg170543

keywords: + patch
2012-09-08 20:57:42kyle.robertssetnosy: + kyle.roberts
2012-09-06 05:18:49ainur0160setnosy: + ainur0160
2012-09-03 20:15:30pitrousetkeywords: + easy
2012-09-01 22:37:15pitrousetnosy: + benjamin.peterson, stutzbach, hynek
2012-08-20 22:05:36pitroucreate