Created on 2012-08-20 19:58 by jeffknupp, last changed 2012-12-14 20:58 by jeffknupp. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_urllib.patch.2 | jeffknupp, 2012-08-20 20:15 | review | ||
| Messages (8) | |||
|---|---|---|---|
| msg168692 - (view) | Author: Jeff Knupp (jeffknupp) * | Date: 2012-08-20 19:58 | |
urllib was updated to deprecate a number of Request methods for 3.3. The test_urllib2 and test_urllib tests still use some of the deprecated methods. |
|||
| msg168693 - (view) | Author: Jeff Knupp (jeffknupp) * | Date: 2012-08-20 19:58 | |
Attaching patch. |
|||
| msg168694 - (view) | Author: Senthil Kumaran (orsenthil) *  |
Date: 2012-08-20 20:02 | |
The patch looks good to me. Thanks Jeff. |
|||
| msg168695 - (view) | Author: Jeff Knupp (jeffknupp) * | Date: 2012-08-20 20:15 | |
Updated with correct patch file. |
|||
| msg168696 - (view) | Author: Jeff Knupp (jeffknupp) * | Date: 2012-08-20 20:17 | |
Senthil, sorry, missed your comment and hadn't realized anyone had seen the patch yet. I replaced it with an updated version (had missed a few places deprecated functions were used). Could you review the new patch instead? |
|||
| msg168697 - (view) | Author: Senthil Kumaran (orsenthil) * |
Date: 2012-08-20 20:20 | |
One change. get_method has only been changed not deprecated. Those test cases should not change and moreover the current change to assert against .method results in a failure too. get_method would return "GET" when .method is None or empty. |
|||
| msg168698 - (view) | Author: Jeff Knupp (jeffknupp) * | Date: 2012-08-20 20:23 | |
Yes, that was part of the original patch which was incorrectly uploaded. The current patch (2) should be correct wrt get_method. |
|||
| msg168700 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-08-20 20:46 | |
New changeset 9b28dff66ac3 by Senthil Kumaran in branch 'default': Fix Issue 15743 - improve urllib tests by removing deprecated method usages. Patch by Jeff Knupp. http://hg.python.org/cpython/rev/9b28dff66ac3 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-12-14 20:58:38 | jeffknupp | set | status: open -> closed resolution: fixed |
| 2012-08-20 20:46:26 | python-dev | set | nosy:
+ python-dev messages: + msg168700 |
| 2012-08-20 20:23:07 | jeffknupp | set | messages: + msg168698 |
| 2012-08-20 20:20:16 | orsenthil | set | messages: + msg168697 |
| 2012-08-20 20:17:13 | jeffknupp | set | messages: + msg168696 |
| 2012-08-20 20:15:29 | jeffknupp | set | files:
+ test_urllib.patch.2 messages: + msg168695 |
| 2012-08-20 20:14:04 | jeffknupp | set | files: - test_urllib.patch |
| 2012-08-20 20:02:06 | orsenthil | set | messages: + msg168694 |
| 2012-08-20 20:01:32 | orsenthil | set | assignee: orsenthil nosy: + orsenthil |
| 2012-08-20 19:59:00 | jeffknupp | set | files:
+ test_urllib.patch keywords: + patch messages: + msg168693 |
| 2012-08-20 19:58:18 | jeffknupp | create | |