classification
Title: finish exposing WindowsRegistryImporter in importlib
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: brett.cannon, eric.snow, loewis, ncoghlan, pitrou
Priority: normal Keywords: needs review, patch

Created on 2012-08-01 02:29 by eric.snow, last changed 2012-08-02 11:50 by ncoghlan. This issue is now closed.

Files
File name Uploaded Description Edit
issue15519_expose_importer.diff eric.snow, 2012-08-01 02:39 with doc changes review
Messages (9)
msg167074 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2012-08-01 02:29
1. add to importlib.machinery
2. register on importlib.abc.Finder

patch in a moment.
msg167129 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-08-01 14:01
I'm not sure why some finders are named "Finder" and others "Importer". It makes things confusing.
msg167135 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2012-08-01 14:57
The importers can both find and load modules (e.g. BuiltinImporter defines both find_module() and load_module()), while the finders only find modules (e.g. only define find_module()). It's defined in the glossary, so maybe more links to that would help.
msg167136 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-08-01 15:01
> The importers can both find and load modules (e.g. BuiltinImporter
> defines both find_module() and load_module()), while the finders only
> find modules (e.g. only define find_module()).

Ah, fair enough. I thought loader objects were always distinct from
finders.
msg167148 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2012-08-01 16:57
Also, WindowsRegistryImporter is misnamed.  It should be WindowsRegistryFinder (see issue15502).  Depending on the patch there, I'll update the one here.
msg167149 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2012-08-01 17:00
I guess the real question here is if anyone has problems with adding WindowsRegistryFinder to importlib.machinery (and to the importlib docs).  If it should stay private than I'd like to throw a _ on the name of the class.  The change to importlib.abc would likely stay either way.
msg167150 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2012-08-01 17:13
It should be exposed (i.e. if SourcelessFileLoader is documented and exposed then so should WindowsRegistryFinder).
msg167202 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2012-08-02 10:22
We'll also want to add this to the inheritance tests in test_importlib.test_abc
msg167208 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2012-08-02 11:50
This didn't close automatically (I assume the open dependency upset matters, since it also prevented me from closing it manually the first time).

Applied to trunk in http://hg.python.org/cpython/rev/a1ac1e13c5a0

(including the rename from #15502)
History
Date User Action Args
2012-08-02 11:50:36ncoghlansetstatus: open -> closed
stage: patch review -> resolved
2012-08-02 11:50:20ncoghlansetresolution: fixed
dependencies: - Meta path finders and path entry finders are different, but share an ABC
messages: + msg167208
2012-08-02 10:22:19ncoghlansetmessages: + msg167202
2012-08-01 17:13:50brett.cannonsetmessages: + msg167150
2012-08-01 17:00:20eric.snowsetmessages: + msg167149
2012-08-01 16:57:18eric.snowsetdependencies: + Meta path finders and path entry finders are different, but share an ABC
messages: + msg167148
2012-08-01 15:01:43pitrousetmessages: + msg167136
2012-08-01 14:57:16brett.cannonsetmessages: + msg167135
2012-08-01 14:01:42pitrousetnosy: + pitrou
messages: + msg167129
2012-08-01 13:34:54ncoghlansetnosy: + ncoghlan
2012-08-01 02:39:14eric.snowsetfiles: + issue15519_expose_importer.diff
2012-08-01 02:38:43eric.snowsetfiles: - issue15519_expose_importer.diff
2012-08-01 02:32:00eric.snowsetfiles: + issue15519_expose_importer.diff
keywords: + patch
2012-08-01 02:29:28eric.snowcreate