Created on 2012-07-30 16:37 by twouters, last changed 2013-01-29 23:08 by python-dev. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| inthandler.patch | twouters, 2012-07-31 00:24 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg166910 - (view) | Author: Thomas Wouters (twouters) *  |
Date: 2012-07-30 16:37 | |
unittest.installHandler incorrectly assumes signal.SIGINT will always be set to a callable object, rather than signal.SIG_DFL or signal.SIG_IGN. This breaks if the test is being executed in an environment that e.g. ignores signal.SIGINT, like a bash script that executes 'make' in a subshell, because an attempt to call the original handler (for whatever reason) causes it to try and call an integer. On top of that, the *tests* for unittest.installHandler in unittest/tests/test_break.py assume not just that signal.SIGINT is set to a callable object, but that they're set to signal.default_int_handler. |
|||
| msg166916 - (view) | Author: Thomas Wouters (twouters) * |
Date: 2012-07-30 18:00 | |
Patch attached. |
|||
| msg166937 - (view) | Author: Thomas Wouters (twouters) * |
Date: 2012-07-31 00:24 | |
Updated patch. |
|||
| msg180946 - (view) | Author: Thomas Wouters (twouters) * |
Date: 2013-01-29 20:43 | |
ping (you know why :) |
|||
| msg180955 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-01-29 22:59 | |
New changeset 7e4c5914ba76 by Michael Foord in branch '2.7': Issue 15505. unittest.installHandler and non callable signal handlers http://hg.python.org/cpython/rev/7e4c5914ba76 |
|||
| msg180956 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-01-29 23:08 | |
New changeset 48c5c632d212 by Michael Foord in branch '3.2': Closes issue 15505. unittest.installHandler and non-callable signal handlers. http://hg.python.org/cpython/rev/48c5c632d212 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-01-29 23:08:14 | python-dev | set | status: open -> closed resolution: fixed messages: + msg180956 stage: patch review -> resolved |
| 2013-01-29 22:59:06 | python-dev | set | nosy:
+ python-dev messages: + msg180955 |
| 2013-01-29 20:45:05 | pitrou | set | nosy:
+ ezio.melotti |
| 2013-01-29 20:43:56 | twouters | set | messages: + msg180946 |
| 2012-09-30 10:18:28 | tomwardill | set | nosy:
+ michael.foord |
| 2012-07-31 00:24:13 | twouters | set | files: - inthandler.patch |
| 2012-07-31 00:24:02 | twouters | set | files:
+ inthandler.patch messages: + msg166937 |
| 2012-07-30 18:44:59 | gregory.p.smith | set | keywords:
+ needs review assignee: gregory.p.smith nosy: + gregory.p.smith |
| 2012-07-30 18:00:05 | twouters | set | files:
+ inthandler.patch keywords: + patch messages: + msg166916 stage: patch review |
| 2012-07-30 16:37:01 | twouters | create | |