classification
Title: Sleep is hardcoded in webbrowser.UnixBrowser
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: jcea Nosy List: anton.barkovsky, jcea, python-dev
Priority: normal Keywords: patch

Created on 2012-07-30 11:18 by anton.barkovsky, last changed 2012-08-01 01:58 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
webbrowser_sleep.patch anton.barkovsky, 2012-07-30 11:18 Use Popen.wait instead of sleeping in webbrowser.UnixBrowser._invoke review
Messages (3)
msg166877 - (view) Author: Anton Barkovsky (anton.barkovsky) * Date: 2012-07-30 11:18
webbrowser.UnixBrowser._invoke will sleep for at least 1 second after
launching browser process and then probably 4 more seconds. These numbers
are hardcoded and can't be modified which is especially problematic for
testing.

I think this code should be replaced with Popen.wait with timeout.
A patch is attached.
msg167068 - (view) Author: Jesús Cea Avión (jcea) * (Python committer) Date: 2012-08-01 01:57
Thanks. Applying to 3.3.
msg167069 - (view) Author: Roundup Robot (python-dev) Date: 2012-08-01 01:58
New changeset a16403affccd by Jesus Cea in branch 'default':
Closes #15499: Sleep is hardcoded in webbrowser.UnixBrowser
http://hg.python.org/cpython/rev/a16403affccd
History
Date User Action Args
2012-08-01 01:58:09python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg167069

resolution: fixed
stage: resolved
2012-08-01 01:57:48jceasetversions: + Python 3.3, - Python 3.4
nosy: + jcea

messages: + msg167068

assignee: jcea
2012-07-30 11:18:42anton.barkovskycreate