classification
Title: Bug in definition of PyImport_ImportModuleEx macro
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: cstawarz, georg.brandl, nnorwitz (3)
Priority: release blocker Keywords

Created on 2006-08-18 15:10 by cstawarz, last changed 2006-08-19 04:25 by nnorwitz.

Messages (3)
msg29550 - (view) Author: Chris Stawarz (cstawarz) Date: 2006-08-18 15:10 
In Python 2.5c1 and SVN trunk rev 42649, the file
import.h has a bug in the definition of the macro
PyImport_ImportModuleEx.  From the code:

#define PyImport_ImportModuleEx(n, g, l, f) \
        PyImport_ImportModuleLevel(n, g, l, f, -1);

The trailing semicolon shouldn't be there, as it causes
compilation to fail when you do things like

if (NULL == (module = PyImport_ImportModuleEx(...))) ...
msg29551 - (view) Author: Georg Brandl (georg.brandl) Date: 2006-08-18 15:14 
Logged In: YES 
user_id=849994

This seems correct.
msg29552 - (view) Author: Neal Norwitz (nnorwitz) Date: 2006-08-19 04:25 
Logged In: YES 
user_id=33168

Thanks!

Committed revision 51399. (2.5)
Committed revision 51402. (2.6)
History
Date User Action Args
2006-08-18 15:10:15cstawarzcreate