classification
Title: Fix resource leak in support.py:_is_ipv6_enabled
Type: resource usage Stage: resolved
Components: Tests Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: rosslagerwall Nosy List: bbrazil, python-dev, rosslagerwall
Priority: normal Keywords: patch

Created on 2012-07-07 14:16 by bbrazil, last changed 2012-07-07 16:49 by rosslagerwall. This issue is now closed.

Files
File name Uploaded Description Edit
ipv6-enabled-fd-leak-fix.patch bbrazil, 2012-07-07 14:16 review
Messages (4)
msg164855 - (view) Author: Brian Brazil (bbrazil) * Date: 2012-07-07 14:16
I'm running Ubuntu Precise and have net.ipv6.conf.all.disable_ipv6 = 1 in my sysctl.conf. With this configuration at head there's a fd leak in 
_is_ipv6_enabled in support.py when the bind fails, which the attached patch should fix.
msg164907 - (view) Author: Roundup Robot (python-dev) Date: 2012-07-07 16:44
New changeset c9299edf1f67 by Ross Lagerwall in branch 'default':
#15277: Fix a resource leak in support.py when IPv6 is disabled.
http://hg.python.org/cpython/rev/c9299edf1f67
msg164908 - (view) Author: Ross Lagerwall (rosslagerwall) (Python committer) Date: 2012-07-07 16:47
Thanks.

test_socket seems to be broken in all branches when running with net.ipv6.conf.all.disable_ipv6 = 1 but I'll open a new issue for that.
msg164910 - (view) Author: Ross Lagerwall (rosslagerwall) (Python committer) Date: 2012-07-07 16:49
Ah, I see you've already opened a new issue for that (issue15284).
History
Date User Action Args
2012-07-07 16:49:09rosslagerwallsetmessages: + msg164910
2012-07-07 16:47:15rosslagerwallsetstatus: open -> closed

assignee: rosslagerwall
versions: + Python 3.3, - Python 3.4
nosy: + rosslagerwall

messages: + msg164908
resolution: fixed
stage: resolved
2012-07-07 16:44:00python-devsetnosy: + python-dev
messages: + msg164907
2012-07-07 14:16:01bbrazilcreate