Created on 2012-07-04 02:01 by agentultra, last changed 2012-07-07 06:09 by rhettinger.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| set_abc_coverage.patch | agentultra, 2012-07-04 02:01 | review | ||
| set_abc_coverage.patch | agentultra, 2012-07-06 01:19 | review | ||
| Messages (3) | |||
|---|---|---|---|
| msg164632 - (view) | Author: James King (agentultra) | Date: 2012-07-04 02:01 | |
I'm working on increasing the line-coverage of the tests for the Set ABC in the collections.abc module. I encountered something a little funky IMO that I'm not sure is an issue or bug... but the __and__ method passes a generator object to the constructor of the Set subclass' constructor where the code seems to check for Iterator. This makes my naive tests for the '&' operator to fail. So I haven't included them in this patch, statisfied with the equality tests and isdisjoint. First patch, advice welcome. |
|||
| msg164642 - (view) | Author: Mark Dickinson (mark.dickinson) *  |
Date: 2012-07-04 10:22 | |
Can you attach the failing tests for __and__? |
|||
| msg164710 - (view) | Author: James King (agentultra) | Date: 2012-07-06 01:19 | |
How about a working test instead? Let me know if it looks right. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-07-07 06:09:52 | rhettinger | set | assignee: rhettinger |
| 2012-07-06 01:19:21 | agentultra | set | files:
+ set_abc_coverage.patch messages: + msg164710 |
| 2012-07-04 10:22:04 | mark.dickinson | set | nosy:
+ mark.dickinson messages: + msg164642 |
| 2012-07-04 09:48:09 | pitrou | set | nosy:
+ rhettinger, stutzbach stage: patch review |
| 2012-07-04 02:01:56 | agentultra | create | |